Re: [PATCH 4/5] rtc: jz4740_rtc: Add support for acting as the system power controller

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] rtc: jz4740_rtc: Add support for acting as the system power controller
Date	2016-03-17 13:30 +0100
Message-ID	<rdFdT-7nw-7@gated-at.bofh.it> (permalink)
References	<r9tbk-4pS-3@gated-at.bofh.it> <r9tbk-4pS-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/03/2016 at 23:38:50 +0100, Paul Cercueil wrote :
> +	if (of_device_is_system_power_controller(pdev->dev.of_node)) {
> +		if (!pm_power_off) {
> +			/* Default: 60ms */
> +			rtc->reset_pin_assert_time = 60;
> +			device_property_read_u32(&pdev->dev,

It is probably more efficient to use of_property_read_u32 directly. Any
particular reason to use device_property_read_u32?

> +		} else {
> +			dev_err(&pdev->dev,
> +					"Poweroff handler already present!\n");

I'm not found of that alignement, it is probably better to let the
string go over 80 chars. checkpatch will not complain.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/5] rtc: jz4740_rtc: Add support for acting as the system power controller Paul Cercueil <paul@crapouillou.net> - 2016-03-05 23:50 +0100
  Re: [PATCH 4/5] rtc: jz4740_rtc: Add support for acting as the  system power controller Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-03-17 13:30 +0100

csiph-web