Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1359802

RE: [PATCH v11 8/9] arm64: Add kernel return probes support (kretprobes)

Show all headers | View raw

Hi,

>From: Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com>
>
>The pre-handler of this special 'trampoline' kprobe executes the return
>probe handler functions and restores original return address in ELR_EL1.
>This way the saved pt_regs still hold the original register context to be
>carried back to the probed kernel function.

This patch seems not well separated.

>diff --git a/arch/arm64/kernel/kprobes.c b/arch/arm64/kernel/kprobes.c
>index bd3f233..13d3333 100644
>--- a/arch/arm64/kernel/kprobes.c
>+++ b/arch/arm64/kernel/kprobes.c

[snip]

>+void __kprobes arch_prepare_kretprobe(struct kretprobe_instance *ri,
>+				      struct pt_regs *regs)
>+{
>+	ri->ret_addr = (kprobe_opcode_t *)regs->regs[30];
>+
>+	/* replace return addr (x30) with trampoline */
>+	regs->regs[30] = (long)&kretprobe_trampoline;

So, where is the kretprobe_trampoline? It seems that function is
defined in other patch.

>+}
>+
>+int __kprobes arch_trampoline_kprobe(struct kprobe *p)
>+{
>+	return 0;
> }

And what this function is for??

Thank you,

>
> int __init arch_init_kprobes(void)
>--
>2.5.0
>
>
>_______________________________________________
>linux-arm-kernel mailing list
>linux-arm-kernel@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v11 0/9] arm64: Add kernel probes (kprobes) support David Long <dave.long@linaro.org> - 2016-03-09 06:40 +0100
  [PATCH v11 4/9] arm64: add conditional instruction simulation support David Long <dave.long@linaro.org> - 2016-03-09 06:40 +0100
    Re: [PATCH v11 4/9] arm64: add conditional instruction simulation  support Marc Zyngier <marc.zyngier@arm.com> - 2016-03-13 13:10 +0100
      Re: [PATCH v11 4/9] arm64: add conditional instruction simulation  support Pratyush Anand <panand@redhat.com> - 2016-03-14 05:10 +0100
        Re: [PATCH v11 4/9] arm64: add conditional instruction simulation  support Marc Zyngier <marc.zyngier@arm.com> - 2016-03-14 08:40 +0100
          Re: [PATCH v11 4/9] arm64: add conditional instruction simulation  support David Long <dave.long@linaro.org> - 2016-03-21 09:40 +0100
  [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes blacklist David Long <dave.long@linaro.org> - 2016-03-09 06:40 +0100
    Re: [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes blacklist James Morse <james.morse@arm.com> - 2016-03-15 19:50 +0100
      Re: [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes blacklist Pratyush Anand <panand@redhat.com> - 2016-03-16 06:50 +0100
        Re: [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes blacklist James Morse <james.morse@arm.com> - 2016-03-16 11:30 +0100
          Re: [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes blacklist Pratyush Anand <panand@redhat.com> - 2016-03-17 09:00 +0100
            Re: [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes blacklist Pratyush Anand <panand@redhat.com> - 2016-03-18 14:30 +0100
              Re: [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes blacklist James Morse <james.morse@arm.com> - 2016-03-18 15:10 +0100
                Re: [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes blacklist Pratyush Anand <panand@redhat.com> - 2016-03-18 15:50 +0100
                Re: [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes blacklist James Morse <james.morse@arm.com> - 2016-03-18 19:20 +0100
                Re: [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes blacklist Pratyush Anand <panand@redhat.com> - 2016-03-21 06:20 +0100
              Re: [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes blacklist Will Deacon <will.deacon@arm.com> - 2016-03-21 16:00 +0100
                Re: [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes blacklist Pratyush Anand <panand@redhat.com> - 2016-03-22 18:00 +0100
    RE: [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes  blacklist 平松雅巳 / HIRAMATU，MASAMI   <masami.hiramatsu.pt@hitachi.com> - 2016-03-17 13:10 +0100
  [PATCH v11 5/9] arm64: Kprobes with single stepping support David Long <dave.long@linaro.org> - 2016-03-09 06:40 +0100
  [PATCH v11 9/9] kprobes: Add arm64 case in kprobe example module David Long <dave.long@linaro.org> - 2016-03-09 06:40 +0100
  [PATCH v11 2/9] arm64: Add more test functions to insn.c David Long <dave.long@linaro.org> - 2016-03-09 06:40 +0100
  [PATCH v11 8/9] arm64: Add kernel return probes support (kretprobes) David Long <dave.long@linaro.org> - 2016-03-09 06:40 +0100
    RE: [PATCH v11 8/9] arm64: Add kernel return probes support  (kretprobes) 平松雅巳 / HIRAMATU，MASAMI   <masami.hiramatsu.pt@hitachi.com> - 2016-03-17 13:30 +0100
      RE: [PATCH v11 8/9] arm64: Add kernel return probes support  (kretprobes) 平松雅巳 / HIRAMATU，MASAMI   <masami.hiramatsu.pt@hitachi.com> - 2016-03-17 14:00 +0100
        Re: [PATCH v11 8/9] arm64: Add kernel return probes support  (kretprobes) David Long <dave.long@linaro.org> - 2016-03-21 14:40 +0100

csiph-web