Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling events

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling events
Date	2016-03-15 23:00 +0100
Message-ID	<rd5ap-7XV-13@gated-at.bofh.it> (permalink)
References	<raTdn-4Ll-3@gated-at.bofh.it> <raTdn-4Ll-1@gated-at.bofh.it> <rd3rX-73e-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 15, 2016 at 04:06:46PM -0400, Steven Rostedt wrote:
> On Wed,  9 Mar 2016 21:46:41 +0100
> Jiri Olsa <jolsa@kernel.org> wrote:
> 
> > Currently we check sample type for ftrace:function event
> > even if it's not created as sampling event. That prevents
> > creating ftrace_function event in counting mode.
> > 
> > Making sure we check sample types only for sampling events.
> > 
> > Before:
> >   $ sudo perf stat -e ftrace:function ls
> >   ...
> > 
> >    Performance counter stats for 'ls':
> > 
> >      <not supported>      ftrace:function
> > 
> >          0.001983662 seconds time elapsed
> > 
> > After:
> >   $ sudo perf stat -e ftrace:function ls
> 
> I'm assuming you gave yourself admin capabilities, and not any normal
> user may sample function tracing, right?

right ;-)

jirka

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] ftrace perf: Check sample types only for sampling events Jiri Olsa <jolsa@kernel.org> - 2016-03-09 21:50 +0100
  Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling  events Namhyung Kim <namhyung@kernel.org> - 2016-03-10 01:40 +0100
    Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling  events Jiri Olsa <jolsa@redhat.com> - 2016-03-10 08:30 +0100
      Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling  events Jiri Olsa <jolsa@redhat.com> - 2016-03-11 09:40 +0100
        Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling  events Namhyung Kim <namhyung@kernel.org> - 2016-03-11 14:50 +0100
          Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling  events Jiri Olsa <jolsa@redhat.com> - 2016-03-11 19:20 +0100
  Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling  events Steven Rostedt <rostedt@goodmis.org> - 2016-03-15 21:10 +0100
    Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling  events Jiri Olsa <jolsa@redhat.com> - 2016-03-15 23:00 +0100

csiph-web