Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1354433

[PATCH 1/5] ftrace perf: Check sample types only for sampling events

Show all headers | View raw

Currently we check sample type for ftrace:function event
even if it's not created as sampling event. That prevents
creating ftrace_function event in counting mode.

Making sure we check sample types only for sampling events.

Before:
  $ sudo perf stat -e ftrace:function ls
  ...

   Performance counter stats for 'ls':

     <not supported>      ftrace:function

         0.001983662 seconds time elapsed

After:
  $ sudo perf stat -e ftrace:function ls
  ...

   Performance counter stats for 'ls':

              44,498      ftrace:function

         0.037534722 seconds time elapsed

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 kernel/trace/trace_event_perf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/trace_event_perf.c b/kernel/trace/trace_event_perf.c
index 00df25fd86ef..a7171ec2c1ca 100644
--- a/kernel/trace/trace_event_perf.c
+++ b/kernel/trace/trace_event_perf.c
@@ -52,14 +52,14 @@ static int perf_trace_event_perm(struct trace_event_call *tp_event,
 		 * event, due to issues with page faults while tracing page
 		 * fault handler and its overall trickiness nature.
 		 */
-		if (!p_event->attr.exclude_callchain_user)
+		if (is_sampling_event(p_event) && !p_event->attr.exclude_callchain_user)
 			return -EINVAL;
 
 		/*
 		 * Same reason to disable user stack dump as for user space
 		 * callchains above.
 		 */
-		if (p_event->attr.sample_type & PERF_SAMPLE_STACK_USER)
+		if (is_sampling_event(p_event) && p_event->attr.sample_type & PERF_SAMPLE_STACK_USER)
 			return -EINVAL;
 	}
 
-- 
2.4.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] ftrace perf: Check sample types only for sampling events Jiri Olsa <jolsa@kernel.org> - 2016-03-09 21:50 +0100
  Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling  events Namhyung Kim <namhyung@kernel.org> - 2016-03-10 01:40 +0100
    Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling  events Jiri Olsa <jolsa@redhat.com> - 2016-03-10 08:30 +0100
      Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling  events Jiri Olsa <jolsa@redhat.com> - 2016-03-11 09:40 +0100
        Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling  events Namhyung Kim <namhyung@kernel.org> - 2016-03-11 14:50 +0100
          Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling  events Jiri Olsa <jolsa@redhat.com> - 2016-03-11 19:20 +0100
  Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling  events Steven Rostedt <rostedt@goodmis.org> - 2016-03-15 21:10 +0100
    Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling  events Jiri Olsa <jolsa@redhat.com> - 2016-03-15 23:00 +0100

csiph-web