Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1358185

Re: [PATCH] devpts: Make ptmx be owned by the userns owner instead of userns-local 0

Show all headers | View raw

On Mar 14, 2016 1:35 AM, "Serge Hallyn" <serge.hallyn@ubuntu.com> wrote:
>
> Quoting Andy Lutomirski (luto@kernel.org):
> > We used to have ptmx be owned by the inner uid and gid 0.  Change
> > this: if the owner and group are both mapped but are not both 0,
> > then use the owner instead.
> >
> > For container-style namespaces (LXC, etc), this should have no
> > effect -- UID 0 is will either be the owner or will be unmapped.
>
> This doesn't seem right - it's often the case that the owner is mapped
> in as non-0 uid, safe or not.  The actual namespace root uid should be
> the owner (so long as it exists).
>
> Why not reverse the cases?  If 0 is not mapped, then check whether the
> current_user_ns()->owner is mapped?

Good point, and less chance of breakage that way as well.

--Andy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] devpts: Make ptmx be owned by the userns owner instead of userns-local 0 Andy Lutomirski <luto@kernel.org> - 2016-03-14 06:10 +0100
  Re: [PATCH] devpts: Make ptmx be owned by the userns owner instead  of userns-local 0 Serge Hallyn <serge.hallyn@ubuntu.com> - 2016-03-14 09:40 +0100
    Re: [PATCH] devpts: Make ptmx be owned by the userns owner instead of  userns-local 0 Andy Lutomirski <luto@amacapital.net> - 2016-03-15 19:30 +0100
  Re: [PATCH] devpts: Make ptmx be owned by the userns owner instead  of userns-local 0 Alexander Larsson <alexl@redhat.com> - 2016-03-14 16:50 +0100

csiph-web