Re: [PATCH v3 01/13] pinctrl: sunxi: Add A83T R_PIO controller support

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 01/13] pinctrl: sunxi: Add A83T R_PIO controller support
Date	2016-03-14 12:00 +0100
Message-ID	<rcyo9-2Ex-7@gated-at.bofh.it> (permalink)
References	<r9mCR-8eS-3@gated-at.bofh.it> <r9mCS-8eS-23@gated-at.bofh.it> <raCvU-1ui-1@gated-at.bofh.it> <rbJEZ-wg-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Sat, Mar 12, 2016 at 12:48:02PM +0800, Vishnu Patekar wrote:
> Hello Linus,
> 
> 
> On Wed, Mar 9, 2016 at 10:55 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Sat, Mar 5, 2016 at 10:42 PM, Vishnu Patekar
> > <vishnupatekar0510@gmail.com> wrote:
> >
> >> The A83T has R_PIO pin controller, it's same as A23, execpt A83T
> >> interrupt bit is 6th and A83T has one extra pin PL12.
> >>
> >> Signed-off-by: Vishnu Patekar <vishnupatekar0510@gmail.com>
> >> Acked-by: Chen-Yu Tsai <wens@csie.org>
> >> Acked-by: Rob Herring <robh@kernel.org>
> >
> > As partly noted by others:
> >
> >> +config PINCTRL_SUN8I_A83T_R
> >> +       def_bool MACH_SUN8I
> >
> > bool
> >
> >> +       depends on RESET_CONTROLLER
> >
> > Should it rather select RESET_CONTROLLER?
> I used depends on and def_bool as it is used for other sunxi pinctrl drivers.
> Using bool and select will not harm anything.

It will, at least in the case of def_bool, since that symbol will not
be enabled by default, and you'll have no way to enable it.

And RESET_CONTROLLER is a bit messy, since you can't just select it
because it also has a dependency on an ARCH_HAS_RESET_CONTROLLER
symbol.

> Should I change it to bool and select ?  or keep it to be uniform with
> earlier options?

Please keep it that way.

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thread

[PATCH v3 00/13] Add A83T clk, r_pio, mmc rsb support Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
  [PATCH v3 13/13] ARM: sunxi: Add Kconfig for sunxi clocks Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
    Re: [PATCH v3 13/13] ARM: sunxi: Add Kconfig for sunxi clocks Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 17:30 +0100
  [PATCH v3 06/13] ARM: dts: sun8i-a83t: Add mmc controller nodes Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
  [PATCH v3 09/13] ARM: dts: sun8i-a83t: Add RSB controller device node to dtsi Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
  [PATCH v3 12/13] ARM: dts: sun8i: Add A83T based Sinovoip Bpi-M3 Board Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
  [PATCH v3 10/13] ARM: dts: sun8i-a83t: add mmc0 CD pin Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
  [PATCH v3 01/13] pinctrl: sunxi: Add A83T R_PIO controller support Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
    Re: [PATCH v3 01/13] pinctrl: sunxi: Add A83T R_PIO controller support Linus Walleij <linus.walleij@linaro.org> - 2016-03-09 04:00 +0100
      Re: [PATCH v3 01/13] pinctrl: sunxi: Add A83T R_PIO controller support Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-12 05:50 +0100
        Re: [PATCH v3 01/13] pinctrl: sunxi: Add A83T R_PIO controller  support Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-03-14 12:00 +0100
  [PATCH v3 02/13] clk: sunxi: add ahb1 clock for A83T Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
    Re: [linux-sunxi] [PATCH v3 02/13] clk: sunxi: add ahb1 clock for A83T Julian Calaby <julian.calaby@gmail.com> - 2016-03-07 03:50 +0100
  [PATCH v3 05/13] ARM: dts: sun8i-a83t: add mmc clock nodes Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
  [PATCH v3 04/13] ARM: dts: sun8i-a83t: Add basic clocks and resets Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
  [PATCH v3 11/13] ARM: dts: sun8i: enable mmc for H8Homlet Board. Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
  [PATCH v3 07/13] ARM: dts: sun8i-a83t: Add PRCM related clocks and resets Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
  [PATCH v3 08/13] ARM: dts: sun8i-a83t: Add R_PIO controller node to the dtsi Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100

csiph-web