Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1353746
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 01/13] pinctrl: sunxi: Add A83T R_PIO controller support |
| Date | 2016-03-09 04:00 +0100 |
| Message-ID | <raCvU-1ui-1@gated-at.bofh.it> (permalink) |
| References | <r9mCR-8eS-3@gated-at.bofh.it> <r9mCS-8eS-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Mar 5, 2016 at 10:42 PM, Vishnu Patekar
<vishnupatekar0510@gmail.com> wrote:
> The A83T has R_PIO pin controller, it's same as A23, execpt A83T
> interrupt bit is 6th and A83T has one extra pin PL12.
>
> Signed-off-by: Vishnu Patekar <vishnupatekar0510@gmail.com>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
> Acked-by: Rob Herring <robh@kernel.org>
As partly noted by others:
> +config PINCTRL_SUN8I_A83T_R
> + def_bool MACH_SUN8I
bool
> + depends on RESET_CONTROLLER
Should it rather select RESET_CONTROLLER?
> +static const struct of_device_id sun8i_a83t_r_pinctrl_match[] = {
> + { .compatible = "allwinner,sun8i-a83t-r-pinctrl", },
> + {}
> +};
> +MODULE_DEVICE_TABLE(of, sun8i_a83t_r_pinctrl_match);
Module talk in bool driver.
> +static struct platform_driver sun8i_a83t_r_pinctrl_driver = {
> + .probe = sun8i_a83t_r_pinctrl_probe,
> + .driver = {
> + .name = "sun8i-a83t-r-pinctrl",
> + .of_match_table = sun8i_a83t_r_pinctrl_match,
> + },
> +};
> +module_platform_driver(sun8i_a83t_r_pinctrl_driver);
Should be builtin?
Yours,
Linus Walleij
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 00/13] Add A83T clk, r_pio, mmc rsb support Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
[PATCH v3 13/13] ARM: sunxi: Add Kconfig for sunxi clocks Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
Re: [PATCH v3 13/13] ARM: sunxi: Add Kconfig for sunxi clocks Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 17:30 +0100
[PATCH v3 06/13] ARM: dts: sun8i-a83t: Add mmc controller nodes Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
[PATCH v3 09/13] ARM: dts: sun8i-a83t: Add RSB controller device node to dtsi Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
[PATCH v3 12/13] ARM: dts: sun8i: Add A83T based Sinovoip Bpi-M3 Board Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
[PATCH v3 10/13] ARM: dts: sun8i-a83t: add mmc0 CD pin Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
[PATCH v3 01/13] pinctrl: sunxi: Add A83T R_PIO controller support Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
Re: [PATCH v3 01/13] pinctrl: sunxi: Add A83T R_PIO controller support Linus Walleij <linus.walleij@linaro.org> - 2016-03-09 04:00 +0100
Re: [PATCH v3 01/13] pinctrl: sunxi: Add A83T R_PIO controller support Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-12 05:50 +0100
Re: [PATCH v3 01/13] pinctrl: sunxi: Add A83T R_PIO controller support Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-03-14 12:00 +0100
[PATCH v3 02/13] clk: sunxi: add ahb1 clock for A83T Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
Re: [linux-sunxi] [PATCH v3 02/13] clk: sunxi: add ahb1 clock for A83T Julian Calaby <julian.calaby@gmail.com> - 2016-03-07 03:50 +0100
[PATCH v3 05/13] ARM: dts: sun8i-a83t: add mmc clock nodes Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
[PATCH v3 04/13] ARM: dts: sun8i-a83t: Add basic clocks and resets Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
[PATCH v3 11/13] ARM: dts: sun8i: enable mmc for H8Homlet Board. Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
[PATCH v3 07/13] ARM: dts: sun8i-a83t: Add PRCM related clocks and resets Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
[PATCH v3 08/13] ARM: dts: sun8i-a83t: Add R_PIO controller node to the dtsi Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-05 16:50 +0100
csiph-web