Re: [PATCH 04/10] ARM: dts: Add MSHC2 dt node for Exynos3250 SoC

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 04/10] ARM: dts: Add MSHC2 dt node for Exynos3250 SoC
Date	Mon, 14 Mar 2016 11:00:01 +0100
Message-ID	<rcxs5-22b-1@gated-at.bofh.it> (permalink)
References	<rcq7g-5Io-5@gated-at.bofh.it> <rcq7g-5Io-3@gated-at.bofh.it> <rcuaS-8sW-7@gated-at.bofh.it> <rcw30-1f4-5@gated-at.bofh.it>
X-Original-To	Chanwoo Choi <cw00.choi@samsung.com>, kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
X-Auditid	cbfec7f5-f79b16d000005389-7f-56e689cfd1a3
Content-Transfer-Encoding	8BIT
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1
X-Brightmail-Tracker	H4sIAAAAAAAAA+NgFvrNLMWRmVeSWpSXmKPExsVy+t/xa7rnO5+FGfTdYLXYfuQZq8X1L89Z LeYfOcdqMen+BBaLG7/aWC1evzC06H/8mtli0+NrrBaXd81hs5hxfh+TxaKtX9gtDr9pZ7WY Mfklm8WqXX8YHfg8ds66y+6xaVUnm8fmJfUefVtWMXp83iQXwBrFZZOSmpNZllqkb5fAlbH+ 5RHWgku8FVM+fmFsYPzH1cXIySEhYCJxeOpVVghbTOLCvfVsXYxcHEICSxklDh25wgSS4BUQ lPgx+R5LFyMHB7OAvMSRS9kQprrElCm5EOVPGSW+blnFAlIuLOApMefLbzYQW0QgW2LGkplQ M/czSjQ0T2EBcZgFmpkk7q5ZBbaATcBYYvPyJWwQy7QkVhz7AmazCKhKnJm7mB3EFhWIkDjc 2QVmcwpoSnxdcZxtAqPALCT3zUK4bxbCfQsYmVcxiqaWJhcUJ6XnGukVJ+YWl+al6yXn525i hETJ1x2MS49ZHWIU4GBU4uH9seZpmBBrYllxZe4hRgkOZiUR3o7mZ2FCvCmJlVWpRfnxRaU5 qcWHGKU5WJTEeWfueh8iJJCeWJKanZpakFoEk2Xi4JRqYExNnzbdXWz3yn2Kn2fftNKOmJXJ 4pjANzG+fOPSSav3r3oRWTnNtdvFwjy/fr+Qd3mIwVErHQHf099eCIZzbf/MsmuzTHTIYQn5 b8cy509fYJ1w5rDD7QWcn1S1PF60324U913LkbWzbE2J7O3PicE7VictSDoWtfPynDlMYjwn Fm6eJpDwdp8SS3FGoqEWc1FxIgDuVuqajgIAAA==
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	47
Organization	linux.* mail to news gateway
X-Original-Cc	jh80.chung@samsung.com, andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
X-Original-Date	Mon, 14 Mar 2016 18:52:09 +0900
X-Original-Message-ID	<56E689C9.6030405@samsung.com>
X-Original-References	<1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-5-git-send-email-cw00.choi@samsung.com> <56E658AE.5070806@samsung.com> <56E67632.30602@samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1357105

Show key headers only | View raw

On 14.03.2016 17:28, Chanwoo Choi wrote:
> On 2016년 03월 14일 15:22, Krzysztof Kozlowski wrote:
>> On 14.03.2016 11:04, Chanwoo Choi wrote:
>>> This patch adds the MSHC2 (Mobile Storage Host Controller) Device Tree node for
>>> Exynos3250 SoC.
>>>
>>> Cc: Kukjin Kim <kgene@kernel.org>
>>> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>> ---
>>>  arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 35 +++++++++++++++++++++++++++++++
>>>  arch/arm/boot/dts/exynos3250.dtsi         | 13 ++++++++++++
>>>  2 files changed, 48 insertions(+)
>>
>>
>> After looking at your other patch ("ARM: dts: Add initial pin
>> configuration for exynos3250-rinato") I have doubts. The Monk will be
>> affected.
> 
> You're right. On monk board, this line may be not stable.
> 
>>
>> Here you are configuring all the gpk2 GPIOS for EMMC2 mode. Then on
>> Rinato you are setting it back to default non-used state. However the
>> Monk board will remain with this new configuration... so you would have
>> to add initial-state also for Monk.
> 
> OK. I'll do it.
> 
>>
>> But how about doing opposite? Configure here the pins to unused state
>> and enable them only for Artik board?
>>
>> What do you think?
> 
> I think that gpk2-[0~6] pins are fixed for MMC2 device.
> So, it is good to add the pin setting for gpk2-[0~6] to exynos3250-pinctrl.dtsi.
> 
> If mmc2 device is not used like rinato and monk board,
> we should add the initial setting as NC (not connected) pin state
> as other patch (ARM: dts: Add initial pin configuration for exynos3250-rinato).

Okay, fine to me.

BR,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 04/10] ARM: dts: Add MSHC2 dt node for Exynos3250 SoC Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-14 03:10 +0100
  Re: [PATCH 04/10] ARM: dts: Add MSHC2 dt node for Exynos3250 SoC Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-14 07:30 +0100
    Re: [PATCH 04/10] ARM: dts: Add MSHC2 dt node for Exynos3250 SoC Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-14 09:30 +0100
      Re: [PATCH 04/10] ARM: dts: Add MSHC2 dt node for Exynos3250 SoC Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-14 11:00 +0100

csiph-web