Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1356662

Re: [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on

From Jianyu Zhan <nasa4836@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on
Date 2016-03-13 11:10 +0100
Message-ID <rcb8e-4dl-7@gated-at.bofh.it> (permalink)
References (6 earlier) <rc96q-2tJ-3@gated-at.bofh.it> <rc9zs-2Vm-3@gated-at.bofh.it> <rcalQ-3zh-11@gated-at.bofh.it> <rcaFc-3ID-19@gated-at.bofh.it> <rcaFc-3ID-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sun, Mar 13, 2016 at 5:33 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
>       IRQ_WORK can work w/o APIC
>
> Emphasis on CAN. If the APIC is available it's used, if not then there is no
> point in setting up the gate for nothing.
>
> So why would your patch do any good?

I understood it is no point setting up if  APIC is not available,  but
just got confused by
your wording 'can',  now all clear.

As for the patch set.   My initial purpose is just wanting to make the
layout clear and
clean up stale comments and dead code:

#ifndef CONFIG_X86_LOCAL_APIC
#define first_system_vector NR_VECTORS
#endif

as we've talked about this before,  it won't ever be change on
!CONFIG_X86_LOCAL_APIC,
so no point define it here(it is initialized to NR_VECTORS).

Since all points are clear now, if  the above purpose still make sense.
I will  respin this patch set.

Thank you for your patient explanation .:-)


Regards,
Jianyu Zhan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] x86/irq: Refactor special vector definition and cleanup Jianyu Zhan <nasa4836@gmail.com> - 2016-03-12 16:10 +0100
  [PATCH 1/3] x86/asm/irq: Rearrange definitoin of specical irq vectors and cleanup. Jianyu Zhan <nasa4836@gmail.com> - 2016-03-12 16:10 +0100
  [PATCH 2/3] x86/irq: refactor native_init_IRQ Jianyu Zhan <nasa4836@gmail.com> - 2016-03-12 16:20 +0100
    Re: [PATCH 2/3] x86/irq: refactor native_init_IRQ kbuild test robot <lkp@intel.com> - 2016-03-12 16:40 +0100
      Re: [PATCH 2/3] x86/irq: refactor native_init_IRQ Jianyu Zhan <nasa4836@gmail.com> - 2016-03-12 16:40 +0100
    Re: [PATCH 2/3] x86/irq: refactor native_init_IRQ kbuild test robot <lkp@intel.com> - 2016-03-12 17:30 +0100
  [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on Jianyu Zhan <nasa4836@gmail.com> - 2016-03-12 16:20 +0100
    Re: [PATCH 3/3] x86/irq: update first_system_vector only when  X86_LOCAL_PIC is on Thomas Gleixner <tglx@linutronix.de> - 2016-03-12 21:20 +0100
      Re: [PATCH 3/3] x86/irq: update first_system_vector only when  X86_LOCAL_PIC is on Jianyu Zhan <nasa4836@gmail.com> - 2016-03-13 02:30 +0100
        Re: [PATCH 3/3] x86/irq: update first_system_vector only when  X86_LOCAL_PIC is on Thomas Gleixner <tglx@linutronix.de> - 2016-03-13 07:40 +0100
          Re: [PATCH 3/3] x86/irq: update first_system_vector only when  X86_LOCAL_PIC is on Jianyu Zhan <nasa4836@gmail.com> - 2016-03-13 08:30 +0100
            Re: [PATCH 3/3] x86/irq: update first_system_vector only when  X86_LOCAL_PIC is on Jianyu Zhan <nasa4836@gmail.com> - 2016-03-13 08:50 +0100
            Re: [PATCH 3/3] x86/irq: update first_system_vector only when  X86_LOCAL_PIC is on Thomas Gleixner <tglx@linutronix.de> - 2016-03-13 09:00 +0100
              Re: [PATCH 3/3] x86/irq: update first_system_vector only when  X86_LOCAL_PIC is on Jianyu Zhan <nasa4836@gmail.com> - 2016-03-13 09:30 +0100
                Re: [PATCH 3/3] x86/irq: update first_system_vector only when  X86_LOCAL_PIC is on Thomas Gleixner <tglx@linutronix.de> - 2016-03-13 10:20 +0100
                Re: [PATCH 3/3] x86/irq: update first_system_vector only when  X86_LOCAL_PIC is on Jianyu Zhan <nasa4836@gmail.com> - 2016-03-13 10:40 +0100
                Re: [PATCH 3/3] x86/irq: update first_system_vector only when  X86_LOCAL_PIC is on Thomas Gleixner <tglx@linutronix.de> - 2016-03-13 10:40 +0100
                Re: [PATCH 3/3] x86/irq: update first_system_vector only when  X86_LOCAL_PIC is on Jianyu Zhan <nasa4836@gmail.com> - 2016-03-13 11:10 +0100
                Re: [PATCH 3/3] x86/irq: update first_system_vector only when  X86_LOCAL_PIC is on Thomas Gleixner <tglx@linutronix.de> - 2016-03-13 12:20 +0100

csiph-web