Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1356535
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on |
| Date | 2016-03-12 21:20 +0100 |
| Message-ID | <rbYb0-393-5@gated-at.bofh.it> (permalink) |
| References | <rbTl0-7Va-15@gated-at.bofh.it> <rbTuG-847-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, 12 Mar 2016, Jianyu Zhan wrote:
> During native_init_IRQ(), we will update first_system_vector conditionally
> when we init system vector. But on !CONFIG_X86_LOCAL_PIC, we prefer it
> to NR_IRQS, so don't bother set it on this case.
>
> Signed-off-by: Jianyu Zhan <nasa4836@gmail.com>
> ---
> arch/x86/include/asm/desc.h | 2 ++
> arch/x86/kernel/irqinit.c | 3 ---
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/include/asm/desc.h b/arch/x86/include/asm/desc.h
> index 4e10d73..4fc2deb 100644
> --- a/arch/x86/include/asm/desc.h
> +++ b/arch/x86/include/asm/desc.h
> @@ -383,8 +383,10 @@ static inline void alloc_system_vector(int vector)
> {
> if (!test_bit(vector, used_vectors)) {
> set_bit(vector, used_vectors);
> +#ifdef CONFIG_X86_LOCAL_APIC
> if (first_system_vector > vector)
> first_system_vector = vector;
> +#endif
This is pointless, because it's only called when local apic is enabled as all
call sites of alloc_intr_gate() depend on CONFIG_X86_LOCAL_APIC ....
> } else {
> BUG();
> }
> diff --git a/arch/x86/kernel/irqinit.c b/arch/x86/kernel/irqinit.c
> index 0e9fa7c..e999b38 100644
> --- a/arch/x86/kernel/irqinit.c
> +++ b/arch/x86/kernel/irqinit.c
> @@ -188,9 +188,6 @@ void __init native_init_IRQ(void)
> * 'special' SMP interrupts)
> */
> i = FIRST_EXTERNAL_VECTOR;
> -#ifndef CONFIG_X86_LOCAL_APIC
> -#define first_system_vector NR_VECTORS
> -#endif
> for_each_clear_bit_from(i, used_vectors, first_system_vector) {
And how exactly is this here supposed to compile when CONFIG_X86_LOCAL_APIC=n?
> /* IA32_SYSCALL_VECTOR could be used in trap_init already. */
> set_intr_gate(i, irq_entries_start +
> --
> 2.4.3
>
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] x86/irq: Refactor special vector definition and cleanup Jianyu Zhan <nasa4836@gmail.com> - 2016-03-12 16:10 +0100
[PATCH 1/3] x86/asm/irq: Rearrange definitoin of specical irq vectors and cleanup. Jianyu Zhan <nasa4836@gmail.com> - 2016-03-12 16:10 +0100
[PATCH 2/3] x86/irq: refactor native_init_IRQ Jianyu Zhan <nasa4836@gmail.com> - 2016-03-12 16:20 +0100
Re: [PATCH 2/3] x86/irq: refactor native_init_IRQ kbuild test robot <lkp@intel.com> - 2016-03-12 16:40 +0100
Re: [PATCH 2/3] x86/irq: refactor native_init_IRQ Jianyu Zhan <nasa4836@gmail.com> - 2016-03-12 16:40 +0100
Re: [PATCH 2/3] x86/irq: refactor native_init_IRQ kbuild test robot <lkp@intel.com> - 2016-03-12 17:30 +0100
[PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on Jianyu Zhan <nasa4836@gmail.com> - 2016-03-12 16:20 +0100
Re: [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on Thomas Gleixner <tglx@linutronix.de> - 2016-03-12 21:20 +0100
Re: [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on Jianyu Zhan <nasa4836@gmail.com> - 2016-03-13 02:30 +0100
Re: [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on Thomas Gleixner <tglx@linutronix.de> - 2016-03-13 07:40 +0100
Re: [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on Jianyu Zhan <nasa4836@gmail.com> - 2016-03-13 08:30 +0100
Re: [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on Jianyu Zhan <nasa4836@gmail.com> - 2016-03-13 08:50 +0100
Re: [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on Thomas Gleixner <tglx@linutronix.de> - 2016-03-13 09:00 +0100
Re: [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on Jianyu Zhan <nasa4836@gmail.com> - 2016-03-13 09:30 +0100
Re: [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on Thomas Gleixner <tglx@linutronix.de> - 2016-03-13 10:20 +0100
Re: [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on Jianyu Zhan <nasa4836@gmail.com> - 2016-03-13 10:40 +0100
Re: [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on Thomas Gleixner <tglx@linutronix.de> - 2016-03-13 10:40 +0100
Re: [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on Jianyu Zhan <nasa4836@gmail.com> - 2016-03-13 11:10 +0100
Re: [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on Thomas Gleixner <tglx@linutronix.de> - 2016-03-13 12:20 +0100
csiph-web