Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1357807
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Al Viro <viro@ZenIV.linux.org.uk> |
| Newsgroups | linux.kernel |
| Subject | Re: linux-next: manual merge of the aio tree with the vfs tree |
| Date | Tue, 15 Mar 2016 06:20:01 +0100 |
| Message-ID | <rcPyF-5ZN-1@gated-at.bofh.it> (permalink) |
| References | <rcOsV-5fI-3@gated-at.bofh.it> <rcOVY-5tH-19@gated-at.bofh.it> <rcPoZ-5Wk-5@gated-at.bofh.it> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2010-09-15) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 13 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Benjamin LaHaise <bcrl@kvack.org>, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org |
| X-Original-Date | Tue, 15 Mar 2016 05:19:39 +0000 |
| X-Original-Message-ID | <20160315051939.GG17997@ZenIV.linux.org.uk> |
| X-Original-References | <20160315150640.02a4db30@canb.auug.org.au> <20160315043448.GE17997@ZenIV.linux.org.uk> <20160315050712.GF17997@ZenIV.linux.org.uk> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1357807 |
Show key headers only | View raw
On Tue, Mar 15, 2016 at 05:07:12AM +0000, Al Viro wrote:
> There *is* a reason for code review. Or, at least, asking somebody familiar
> with the code you are working with whether some assumption you are making
> is true or false. Me, for example, in our conversation regarding earlier parts
> of aio.git queue about a week ago. Or at any other point.
While we are at it, 150a0b49 ("aio: add support for async openat()") is also
crap. fs_struct and files_struct is nowhere near enough. And yes, I realize
that your application probably doesn't step into it. Which means that these
patches are just fine for your private kernel. _Not_ for mainline.
Reviewed-and-NAKed-by: Al Viro <viro@zeniv.linux.org.uk>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
linux-next: manual merge of the aio tree with the vfs tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-15 05:10 +0100
Re: linux-next: manual merge of the aio tree with the vfs tree Al Viro <viro@ZenIV.linux.org.uk> - 2016-03-15 05:40 +0100
Re: linux-next: manual merge of the aio tree with the vfs tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-15 06:00 +0100
Re: linux-next: manual merge of the aio tree with the vfs tree Al Viro <viro@ZenIV.linux.org.uk> - 2016-03-15 06:10 +0100
Re: linux-next: manual merge of the aio tree with the vfs tree Al Viro <viro@ZenIV.linux.org.uk> - 2016-03-15 06:20 +0100
Re: linux-next: manual merge of the aio tree with the vfs tree Benjamin LaHaise <bcrl@kvack.org> - 2016-03-15 14:20 +0100
csiph-web