Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1357807

Re: linux-next: manual merge of the aio tree with the vfs tree

Show all headers | View raw

On Tue, Mar 15, 2016 at 05:07:12AM +0000, Al Viro wrote:

> There *is* a reason for code review.  Or, at least, asking somebody familiar
> with the code you are working with whether some assumption you are making
> is true or false.  Me, for example, in our conversation regarding earlier parts
> of aio.git queue about a week ago.  Or at any other point.

While we are at it, 150a0b49 ("aio: add support for async openat()") is also
crap.  fs_struct and files_struct is nowhere near enough.  And yes, I realize
that your application probably doesn't step into it.  Which means that these
patches are just fine for your private kernel.  _Not_ for mainline.

Reviewed-and-NAKed-by: Al Viro <viro@zeniv.linux.org.uk>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

linux-next: manual merge of the aio tree with the vfs tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-15 05:10 +0100
  Re: linux-next: manual merge of the aio tree with the vfs tree Al Viro <viro@ZenIV.linux.org.uk> - 2016-03-15 05:40 +0100
    Re: linux-next: manual merge of the aio tree with the vfs tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-15 06:00 +0100
    Re: linux-next: manual merge of the aio tree with the vfs tree Al Viro <viro@ZenIV.linux.org.uk> - 2016-03-15 06:10 +0100
      Re: linux-next: manual merge of the aio tree with the vfs tree Al Viro <viro@ZenIV.linux.org.uk> - 2016-03-15 06:20 +0100
        Re: linux-next: manual merge of the aio tree with the vfs tree Benjamin LaHaise <bcrl@kvack.org> - 2016-03-15 14:20 +0100

csiph-web