Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header
Date	2016-03-14 17:40 +0100
Message-ID	<rcDHc-6ja-11@gated-at.bofh.it> (permalink)
References	(2 earlier) <rbRMd-6It-1@gated-at.bofh.it> <rcteO-7Q2-23@gated-at.bofh.it> <rcxs5-22b-11@gated-at.bofh.it> <rcBFn-4SW-11@gated-at.bofh.it> <rcBFn-4SW-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 14, 2016 at 03:19:45PM +0100, Borislav Petkov wrote:
> On Mon, Mar 14, 2016 at 08:37:02PM +0700, Suravee Suthikulpanit wrote:
> > Basically, we are trying to match the current Perf hierarchy for AMD IOMMU
> > (arch/x86/events/amd/iommu.c). I can put it into
> > arch/x86/include/asm/perf_amd_iommu.h. What would you prefer?
> 
> Yeah, I was going to say the same thing - match the hierarchy so that
> there are no confusions between paths. Makes sense to me.

Well there's still the 'perf' vs' events' thing, but also what other
files did you want to put there?

For now I think I prefer a filename without extra directories; we can
always move files about if there's more use later.

Also, since its being used by both events/amd/iommu.c and
drivers/iommu/amd_iommu.c you can also chose a name in the latter
namespace.

Thread

Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move  perf_event_amd_iommu header Peter Zijlstra <peterz@infradead.org> - 2016-03-12 14:30 +0100
  Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move  perf_event_amd_iommu header Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> - 2016-03-14 06:30 +0100
    Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move  perf_event_amd_iommu header Peter Zijlstra <peterz@infradead.org> - 2016-03-14 11:00 +0100
      Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move  perf_event_amd_iommu header Borislav Petkov <bp@alien8.de> - 2016-03-14 15:30 +0100
        Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move  perf_event_amd_iommu header Peter Zijlstra <peterz@infradead.org> - 2016-03-14 17:40 +0100
          Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move  perf_event_amd_iommu header Peter Zijlstra <peterz@infradead.org> - 2016-03-15 09:50 +0100
          Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move  perf_event_amd_iommu header Borislav Petkov <bp@alien8.de> - 2016-03-15 11:50 +0100
            Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move  perf_event_amd_iommu header Peter Zijlstra <peterz@infradead.org> - 2016-03-15 12:00 +0100

csiph-web