Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header
Date	2016-03-12 14:30 +0100
Message-ID	<rbRMd-6It-1@gated-at.bofh.it> (permalink)
References	<r5lYJ-6Bs-3@gated-at.bofh.it> <r5lYJ-6Bs-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Feb 23, 2016 at 08:12:36AM -0600, Suravee Suthikulpanit wrote:
> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> 
> First, this patch move arch/x86/events/amd/iommu.h to
> arch/x86/include/asm/perf/amd/iommu.h so that we easily include
> it in both perf-amd-iommu and amd-iommu drivers.
> 
> Then, we consolidate declaration of AMD IOMMU performance counter
> APIs into one file.

These seem two independent thingies; should this therefore not be 2
patches?

> Reviewed-by: Joerg Roedel <jroedel@suse.de>
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
> ---
>  arch/x86/events/amd/iommu.c           |  2 +-
>  arch/x86/events/amd/iommu.h           | 40 ---------------------------------
>  arch/x86/include/asm/perf/amd/iommu.h | 42 +++++++++++++++++++++++++++++++++++

That seems somewhat excessive. Not only do you create
arch/x86/include/asm/perf/ you then put another directory on top of
that.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move  perf_event_amd_iommu header Peter Zijlstra <peterz@infradead.org> - 2016-03-12 14:30 +0100
  Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move  perf_event_amd_iommu header Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> - 2016-03-14 06:30 +0100
    Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move  perf_event_amd_iommu header Peter Zijlstra <peterz@infradead.org> - 2016-03-14 11:00 +0100
      Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move  perf_event_amd_iommu header Borislav Petkov <bp@alien8.de> - 2016-03-14 15:30 +0100
        Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move  perf_event_amd_iommu header Peter Zijlstra <peterz@infradead.org> - 2016-03-14 17:40 +0100
          Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move  perf_event_amd_iommu header Peter Zijlstra <peterz@infradead.org> - 2016-03-15 09:50 +0100
          Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move  perf_event_amd_iommu header Borislav Petkov <bp@alien8.de> - 2016-03-15 11:50 +0100
            Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move  perf_event_amd_iommu header Peter Zijlstra <peterz@infradead.org> - 2016-03-15 12:00 +0100

csiph-web