Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1357309

Re: [PATCH 2/2] s390/cpum_sf: Fix cpu hotplug notifier transitions

Show all headers | View raw

On Mon, Mar 14, 2016 at 09:51:50AM +0100, Heiko Carstens wrote:
> On Fri, Mar 11, 2016 at 11:52:38AM +0100, Anna-Maria Gleixner wrote:
> > The cpumf_pmu_notfier() hotplug callback lacks handling of the
> > CPU_DOWN_FAILED case. That means, if CPU_DOWN_PREPARE failes, the PMC
> > of the CPU is not setup again. Furthermore the CPU_ONLINE_FROZEN case
> > will never be processed because of masking the switch expression with
> > CPU_TASKS_FROZEN.
> > 
> > Add handling for CPU_DOWN_FAILED transition to setup the PMC of the
> > CPU. Remove CPU_ONLINE_FROZEN case.
> > 
> > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> > Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> > Cc: linux-s390@vger.kernel.org
> > Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> > ---
> >  arch/s390/kernel/perf_cpum_sf.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- a/arch/s390/kernel/perf_cpum_sf.c
> > +++ b/arch/s390/kernel/perf_cpum_sf.c
> > @@ -1518,7 +1518,7 @@ static int cpumf_pmu_notifier(struct not
> > 
> >  	switch (action & ~CPU_TASKS_FROZEN) {
> >  	case CPU_ONLINE:
> > -	case CPU_ONLINE_FROZEN:
> > +	case CPU_DOWN_FAILED:

The change looks ok for me.

Acked-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>

> >  		flags = PMC_INIT;
> >  		smp_call_function_single(cpu, setup_pmc_cpu, &flags, 1);
> >  		break;
> 
> This is a bit odd, but independent from your patch: setup_pmc_cpu() will
> only deallocate buffers but not allocate them.

That's right.  Allocation is done when an perf event is about to be scheduled
on a CPU.

> 
> Looking at the code a bit further this seems to imply that sampling will
> not work on cpus that were added later.

That might be a problem for task-based perf events.  I will have a closer
look into that issue.

Many thanks.

Kind regards,
  Hendrik

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] s390: Hotplug notifier transitions Anna-Maria Gleixner <anna-maria@linutronix.de> - 2016-03-11 12:00 +0100
  [PATCH 2/2] s390/cpum_sf: Fix cpu hotplug notifier transitions Anna-Maria Gleixner <anna-maria@linutronix.de> - 2016-03-11 12:00 +0100
    Re: [PATCH 2/2] s390/cpum_sf: Fix cpu hotplug notifier transitions Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-03-14 10:00 +0100
      Re: [PATCH 2/2] s390/cpum_sf: Fix cpu hotplug notifier transitions Hendrik Brueckner <brueckner@linux.vnet.ibm.com> - 2016-03-14 15:50 +0100
  Re: [PATCH 0/2] s390: Hotplug notifier transitions Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-03-14 16:50 +0100

csiph-web