Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1355818
| From | Anna-Maria Gleixner <anna-maria@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/2] s390/cpum_sf: Fix cpu hotplug notifier transitions |
| Date | 2016-03-11 12:00 +0100 |
| Message-ID | <rbsXw-4QJ-33@gated-at.bofh.it> (permalink) |
| References | <rbsXw-4QJ-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The cpumf_pmu_notfier() hotplug callback lacks handling of the
CPU_DOWN_FAILED case. That means, if CPU_DOWN_PREPARE failes, the PMC
of the CPU is not setup again. Furthermore the CPU_ONLINE_FROZEN case
will never be processed because of masking the switch expression with
CPU_TASKS_FROZEN.
Add handling for CPU_DOWN_FAILED transition to setup the PMC of the
CPU. Remove CPU_ONLINE_FROZEN case.
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux-s390@vger.kernel.org
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
---
arch/s390/kernel/perf_cpum_sf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/s390/kernel/perf_cpum_sf.c
+++ b/arch/s390/kernel/perf_cpum_sf.c
@@ -1518,7 +1518,7 @@ static int cpumf_pmu_notifier(struct not
switch (action & ~CPU_TASKS_FROZEN) {
case CPU_ONLINE:
- case CPU_ONLINE_FROZEN:
+ case CPU_DOWN_FAILED:
flags = PMC_INIT;
smp_call_function_single(cpu, setup_pmc_cpu, &flags, 1);
break;
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] s390: Hotplug notifier transitions Anna-Maria Gleixner <anna-maria@linutronix.de> - 2016-03-11 12:00 +0100
[PATCH 2/2] s390/cpum_sf: Fix cpu hotplug notifier transitions Anna-Maria Gleixner <anna-maria@linutronix.de> - 2016-03-11 12:00 +0100
Re: [PATCH 2/2] s390/cpum_sf: Fix cpu hotplug notifier transitions Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-03-14 10:00 +0100
Re: [PATCH 2/2] s390/cpum_sf: Fix cpu hotplug notifier transitions Hendrik Brueckner <brueckner@linux.vnet.ibm.com> - 2016-03-14 15:50 +0100
Re: [PATCH 0/2] s390: Hotplug notifier transitions Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-03-14 16:50 +0100
csiph-web