Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1352882

[PATCH 3/5] regulator: pwm: Prints error number when it fails

From Laxman Dewangan <ldewangan@nvidia.com>
Newsgroups linux.kernel
Subject [PATCH 3/5] regulator: pwm: Prints error number when it fails
Date 2016-03-08 12:10 +0100
Message-ID <ranGy-8tF-15@gated-at.bofh.it> (permalink)
References <ranGx-8tF-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Prints the error number along with error message when any
error occurs. This helps on getting the reason of failure
quickly from log without any code instrument.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/regulator/pwm-regulator.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c
index 4689d62..9db67a1 100644
--- a/drivers/regulator/pwm-regulator.c
+++ b/drivers/regulator/pwm-regulator.c
@@ -277,16 +277,18 @@ static int pwm_regulator_probe(struct platform_device *pdev)
 
 	drvdata->pwm = devm_pwm_get(&pdev->dev, NULL);
 	if (IS_ERR(drvdata->pwm)) {
-		dev_err(&pdev->dev, "Failed to get PWM\n");
-		return PTR_ERR(drvdata->pwm);
+		ret = PTR_ERR(drvdata->pwm);
+		dev_err(&pdev->dev, "Failed to get PWM, %d\n", ret);
+		return ret;
 	}
 
 	regulator = devm_regulator_register(&pdev->dev,
 					    &drvdata->desc, &config);
 	if (IS_ERR(regulator)) {
-		dev_err(&pdev->dev, "Failed to register regulator %s\n",
-			drvdata->desc.name);
-		return PTR_ERR(regulator);
+		ret = PTR_ERR(regulator);
+		dev_err(&pdev->dev, "Failed to register regulator %s, %d\n",
+			drvdata->desc.name, ret);
+		return ret;
 	}
 
 	return 0;
-- 
2.1.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/5] regulator: pwm: Add supports for multiple instance and voltage linear steps Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 12:10 +0100
  [PATCH 2/5] regulator: pwm: Add support to have multiple instance of pwm regulator Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 12:10 +0100
  [PATCH 3/5] regulator: pwm: Prints error number when it fails Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 12:10 +0100
    Re: [PATCH 3/5] regulator: pwm: Prints error number when it fails Mark Brown <broonie@kernel.org> - 2016-03-13 09:40 +0100
      Re: [PATCH 3/5] regulator: pwm: Prints error number when it fails Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-13 14:30 +0100
  [PATCH 1/5] regulator: pwm: Fix calculation of voltage-to-duty cycle Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 12:10 +0100
  [PATCH 5/5] regulator: pwm: Add DT binding details for Linear Equal Step Mode Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 12:10 +0100
    Re: [PATCH 5/5] regulator: pwm: Add DT binding details for Linear  Equal Step Mode Rob Herring <robh@kernel.org> - 2016-03-17 16:30 +0100
  [PATCH 4/5] regulator: pwm: Add support for voltage linear equal steps Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 12:10 +0100
    Re: [PATCH 4/5] regulator: pwm: Add support for voltage linear equal  steps Mark Brown <broonie@kernel.org> - 2016-03-13 09:40 +0100
      Re: [PATCH 4/5] regulator: pwm: Add support for voltage linear equal  steps Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-13 14:20 +0100
        Re: [PATCH 4/5] regulator: pwm: Add support for voltage linear equal  steps Mark Brown <broonie@kernel.org> - 2016-03-14 17:30 +0100
          Re: [PATCH 4/5] regulator: pwm: Add support for voltage linear equal  steps Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-15 08:00 +0100

csiph-web