Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1352881

[PATCH 2/5] regulator: pwm: Add support to have multiple instance of pwm regulator

From Laxman Dewangan <ldewangan@nvidia.com>
Newsgroups linux.kernel
Subject [PATCH 2/5] regulator: pwm: Add support to have multiple instance of pwm regulator
Date 2016-03-08 12:10 +0100
Message-ID <ranGx-8tF-9@gated-at.bofh.it> (permalink)
References <ranGx-8tF-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Some of platforms like Nvidia's Tegra210 Jetson-TX1 platform has
multiple PMW based regulators. Add support to have multiple instances
of the driver by not changing any global data of pwm regulator and
if required, making instance specific copy and then making changes.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/regulator/pwm-regulator.c | 27 ++++++++++++++++++++-------
 1 file changed, 20 insertions(+), 7 deletions(-)

diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c
index 4d8eb35..4689d62 100644
--- a/drivers/regulator/pwm-regulator.c
+++ b/drivers/regulator/pwm-regulator.c
@@ -27,6 +27,13 @@ struct pwm_regulator_data {
 
 	/* Voltage table */
 	struct pwm_voltages *duty_cycle_table;
+
+	/* regulator descriptor */
+	struct regulator_desc desc;
+
+	/* Regulator ops */
+	struct regulator_ops ops;
+
 	int state;
 
 	/* Continuous voltage */
@@ -212,8 +219,10 @@ static int pwm_regulator_init_table(struct platform_device *pdev,
 	}
 
 	drvdata->duty_cycle_table	= duty_cycle_table;
-	pwm_regulator_desc.ops		= &pwm_regulator_voltage_table_ops;
-	pwm_regulator_desc.n_voltages	= length / sizeof(*duty_cycle_table);
+	memcpy(&drvdata->ops, &pwm_regulator_voltage_table_ops,
+	       sizeof(drvdata->ops));
+	drvdata->desc.ops = &drvdata->ops;
+	drvdata->desc.n_voltages	= length / sizeof(*duty_cycle_table);
 
 	return 0;
 }
@@ -221,8 +230,10 @@ static int pwm_regulator_init_table(struct platform_device *pdev,
 static int pwm_regulator_init_continuous(struct platform_device *pdev,
 					 struct pwm_regulator_data *drvdata)
 {
-	pwm_regulator_desc.ops = &pwm_regulator_voltage_continuous_ops;
-	pwm_regulator_desc.continuous_voltage_range = true;
+	memcpy(&drvdata->ops, &pwm_regulator_voltage_continuous_ops,
+	       sizeof(drvdata->ops));
+	drvdata->desc.ops = &drvdata->ops;
+	drvdata->desc.continuous_voltage_range = true;
 
 	return 0;
 }
@@ -245,6 +256,8 @@ static int pwm_regulator_probe(struct platform_device *pdev)
 	if (!drvdata)
 		return -ENOMEM;
 
+	memcpy(&drvdata->desc, &pwm_regulator_desc, sizeof(drvdata->desc));
+
 	if (of_find_property(np, "voltage-table", NULL))
 		ret = pwm_regulator_init_table(pdev, drvdata);
 	else
@@ -253,7 +266,7 @@ static int pwm_regulator_probe(struct platform_device *pdev)
 		return ret;
 
 	init_data = of_get_regulator_init_data(&pdev->dev, np,
-					       &pwm_regulator_desc);
+					       &drvdata->desc);
 	if (!init_data)
 		return -ENOMEM;
 
@@ -269,10 +282,10 @@ static int pwm_regulator_probe(struct platform_device *pdev)
 	}
 
 	regulator = devm_regulator_register(&pdev->dev,
-					    &pwm_regulator_desc, &config);
+					    &drvdata->desc, &config);
 	if (IS_ERR(regulator)) {
 		dev_err(&pdev->dev, "Failed to register regulator %s\n",
-			pwm_regulator_desc.name);
+			drvdata->desc.name);
 		return PTR_ERR(regulator);
 	}
 
-- 
2.1.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/5] regulator: pwm: Add supports for multiple instance and voltage linear steps Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 12:10 +0100
  [PATCH 2/5] regulator: pwm: Add support to have multiple instance of pwm regulator Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 12:10 +0100
  [PATCH 3/5] regulator: pwm: Prints error number when it fails Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 12:10 +0100
    Re: [PATCH 3/5] regulator: pwm: Prints error number when it fails Mark Brown <broonie@kernel.org> - 2016-03-13 09:40 +0100
      Re: [PATCH 3/5] regulator: pwm: Prints error number when it fails Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-13 14:30 +0100
  [PATCH 1/5] regulator: pwm: Fix calculation of voltage-to-duty cycle Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 12:10 +0100
  [PATCH 5/5] regulator: pwm: Add DT binding details for Linear Equal Step Mode Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 12:10 +0100
    Re: [PATCH 5/5] regulator: pwm: Add DT binding details for Linear  Equal Step Mode Rob Herring <robh@kernel.org> - 2016-03-17 16:30 +0100
  [PATCH 4/5] regulator: pwm: Add support for voltage linear equal steps Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 12:10 +0100
    Re: [PATCH 4/5] regulator: pwm: Add support for voltage linear equal  steps Mark Brown <broonie@kernel.org> - 2016-03-13 09:40 +0100
      Re: [PATCH 4/5] regulator: pwm: Add support for voltage linear equal  steps Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-13 14:20 +0100
        Re: [PATCH 4/5] regulator: pwm: Add support for voltage linear equal  steps Mark Brown <broonie@kernel.org> - 2016-03-14 17:30 +0100
          Re: [PATCH 4/5] regulator: pwm: Add support for voltage linear equal  steps Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-15 08:00 +0100

csiph-web