Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1351960

Re: [PATCH net-next] hv_netvsc: Move subchannel waiting to rndis_filter_device_remove()

Show all headers | View raw

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Fri,  4 Mar 2016 15:07:43 -0800

> During hot add, vmbus_device_register() is called from vmbus_onoffer(), on
> the same workqueue as the subchannel offer message work-queue, so 
> subchannel offer won't be processed until the vmbus_device_register()/...
> /netvsc_probe() is done.
> Also, vmbus_device_register() is called with channel_mutex locked, which
> prevents subchannel processing too. So the "waiting for sub-channel 
> processing" will not success in hot add case. But, in usual module loading,
> the netvsc_probe() is called from different code path, and doesn't fail.
> 
> This patch resolves the deadlock during NIC hot-add, and speeds up NIC 
> loading time.
> 
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] hv_netvsc: Move subchannel waiting to rndis_filter_device_remove() Haiyang Zhang <haiyangz@microsoft.com> - 2016-03-04 22:30 +0100
  Re: [PATCH net-next] hv_netvsc: Move subchannel waiting to  rndis_filter_device_remove() David Miller <davem@davemloft.net> - 2016-03-07 21:40 +0100

csiph-web