Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1353884

Re: [RESENT PATCH] mmc: block: fix ABI regression of mmc_blk_ioctl

Show all headers | View raw

On Mon, Mar 7, 2016 at 1:59 PM, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> We should return -EINVAL if cmd is not MMC_IOC_CMD or MMC_IOC_MULTI_CMD,
> otherwise blkdev_roset will return -EPERM.
>
> Android-adb calls make_block_device_writable with ioctl(BLKROSET), which
> will return error, make remount failed:
> remount of /system failed;
> couldn't make block device writable: Operation not permitted
>
> openat(AT_FDCWD, "/dev/block/platform/ff420000.dwmmc/by-name/system", O_RDONLY) = 3
> ioctl(3, BLKROSET, 0)  = -1 EPERM (Operation not permitted)
>
> Fixes: a5f5774c55a2 ("mmc: block: Add new ioctl to send multi commands")
> Cc: stable@vger.kernel.org
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>


Ulf,
   We're hitting this as well, and Shawn's patch seems to fix it for me.

Tested-by: John Stultz <john.stultz@linaro.org>

Thanks Shawn!
-john

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RESENT PATCH] mmc: block: fix ABI regression of mmc_blk_ioctl Shawn Lin <shawn.lin@rock-chips.com> - 2016-03-07 08:10 +0100
  Re: [RESENT PATCH] mmc: block: fix ABI regression of mmc_blk_ioctl John Stultz <john.stultz@linaro.org> - 2016-03-09 09:00 +0100
  Re: [RESENT PATCH] mmc: block: fix ABI regression of mmc_blk_ioctl Jon Hunter <jonathanh@nvidia.com> - 2016-03-09 12:00 +0100
    Re: [RESENT PATCH] mmc: block: fix ABI regression of mmc_blk_ioctl Shawn Lin <shawn.lin@kernel-upstream.org> - 2016-03-09 15:10 +0100
      Re: [RESENT PATCH] mmc: block: fix ABI regression of mmc_blk_ioctl Ulf Hansson <ulf.hansson@linaro.org> - 2016-03-16 10:30 +0100

csiph-web