Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1353790
| From | Clinton Sprain <clintonsprain@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] platform/chrome: cros_ec_lightbar - use name instead of ID to hide lightbar attributes |
| Date | 2016-03-09 05:40 +0100 |
| Message-ID | <raE4F-2Fj-5@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Lightbar attributes are hidden if the ID of the device is not 0 (the assumption being that 0 = cros_ec = might have a lightbar, 1 = cros_pd = hide); however, sometimes these devices get IDs 1 and 2 (or something else) instead of IDs 0 and 1. This prevents the lightbar attributes from appearing when they should. Proposed change is to instead check whether the name assigned to the device is CROS_EC_DEV_NAME (true for cros_ec, false for cros_pd). Signed-off-by: Clinton Sprain <clintonsprain@gmail.com> --- drivers/platform/chrome/cros_ec_lightbar.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c index ff76405..b6356b3 100644 --- a/drivers/platform/chrome/cros_ec_lightbar.c +++ b/drivers/platform/chrome/cros_ec_lightbar.c @@ -414,7 +414,12 @@ static umode_t cros_ec_lightbar_attrs_are_visible(struct kobject *kobj, struct cros_ec_dev, class_dev); struct platform_device *pdev = container_of(ec->dev, struct platform_device, dev); - if (pdev->id != 0) + struct cros_ec_platform *pdata = pdev->dev.platform_data; + int is_cros_ec; + + is_cros_ec = strcmp(pdata->ec_name, CROS_EC_DEV_NAME); + + if (is_cros_ec != 0) return 0; /* Only instantiate this stuff if the EC has a lightbar */ -- 2.5.0
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] platform/chrome: cros_ec_lightbar - use name instead of ID to hide lightbar attributes Clinton Sprain <clintonsprain@gmail.com> - 2016-03-09 05:40 +0100
csiph-web