Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1353791

Re: [PATCH v2] ARM: dts: add "simple-bus" where "arm,amba-bus" is used alone

Show all headers | View raw

Hi Rob,


2016-03-08 17:49 GMT+09:00 Rob Herring <robh+dt@kernel.org>:
> On Mon, Mar 7, 2016 at 11:46 PM, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>> The compatible string "simple-bus" is well defined in ePAPR, while
>> I see no documentation for the "arm,amba-bus" in ePAPR or under
>> Documentation/devicetree/.
>>
>> DT is also used by other projects than Linux kernel.  It is not a
>> good idea to rely on such an unofficial binding.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>> Changes in v2:
>>   - Rephrase the git-log
>
> [...]
>
>> diff --git a/arch/arm/boot/dts/axm55xx.dtsi b/arch/arm/boot/dts/axm55xx.dtsi
>> index ea288f0..8da4582 100644
>> --- a/arch/arm/boot/dts/axm55xx.dtsi
>> +++ b/arch/arm/boot/dts/axm55xx.dtsi
>> @@ -107,7 +107,7 @@
>>                 };
>>
>>                 amba {
>> -                       compatible = "arm,amba-bus";
>> +                       compatible = "arm,amba-bus", "simple-bus";
>
> As I mentioned in the last version, I think you should remove
> arm,amba-bus and just have simple-bus. I don't believe anything relies
> on having arm,amba-bus.

Sorry about this.

V3 is here now:
https://patchwork.kernel.org/patch/8542031/




-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] ARM: dts: add "simple-bus" where "arm,amba-bus" is used alone Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-03-08 06:50 +0100
  Re: [PATCH v2] ARM: dts: add "simple-bus" where "arm,amba-bus" is  used alone Rob Herring <robh+dt@kernel.org> - 2016-03-08 10:00 +0100
    Re: [PATCH v2] ARM: dts: add "simple-bus" where "arm,amba-bus" is  used alone Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-08 10:00 +0100
    Re: [PATCH v2] ARM: dts: add "simple-bus" where "arm,amba-bus" is  used alone Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-03-09 05:40 +0100

csiph-web