Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1451374

Re: [PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments

From Mathieu OTHACEHE <m.othacehe@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments
Date 2016-07-27 18:10 +0200
Message-ID <rZzzc-1Cb-27@gated-at.bofh.it> (permalink)
References <rZsel-5j9-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi,

> this makes me think something is wrong with the data structure.
> We should have a be32 there, it seems to me.

You mean something like :

struct ti_write_data_bytes {
	u8	bAddrType;
	u8	bDataType;
	u8	bDataCounter;
	__be32	wBaseAddr;
	u8	bData[0];
} __packed;

and,

data->wBaseAddr = cpu_to_be32(addr) ?

Thanks,

Mathieu

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-07-26 20:10 +0200
  Re: [PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change  ti_write_byte function arguments Oliver Neukum <oneukum@suse.com> - 2016-07-27 10:20 +0200
    Re: [PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-07-27 18:10 +0200
      Re: [PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change  ti_write_byte function arguments Oliver Neukum <oneukum@suse.com> - 2016-07-27 21:20 +0200

csiph-web