Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1451112
| From | Oliver Neukum <oneukum@suse.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments |
| Date | 2016-07-27 10:20 +0200 |
| Message-ID | <rZsel-5j9-7@gated-at.bofh.it> (permalink) |
| References | <rZeXL-5o9-5@gated-at.bofh.it> <rZeXM-5o9-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 2016-07-26 at 19:59 +0200, Mathieu OTHACEHE wrote: > @@ -1626,7 +1624,7 @@ static int ti_write_byte(struct usb_serial_port > *port, > data->bAddrType = TI_RW_DATA_ADDR_XDATA; > data->bDataType = TI_RW_DATA_BYTE; > data->bDataCounter = 1; > - data->wBaseAddrHi = cpu_to_be16(addr>>16); > + data->wBaseAddrHi = cpu_to_be16(addr >> 16); > data->wBaseAddrLo = cpu_to_be16(addr); > data->bData[0] = mask; > data->bData[1] = byte; > -- Hi, this makes me think something is wrong with the data structure. We should have a be32 there, it seems to me. Regards Oliver
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-07-26 20:10 +0200
Re: [PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments Oliver Neukum <oneukum@suse.com> - 2016-07-27 10:20 +0200
Re: [PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-07-27 18:10 +0200
Re: [PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments Oliver Neukum <oneukum@suse.com> - 2016-07-27 21:20 +0200
csiph-web