Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1451173

RE: [PATCH] qed: Add and use specific logging functions to reduce object size

Show all headers | View raw

> > Current DP_ macros generate a lot of code.
> > Using functions with vsprintf extension %pV helps reduce that size.
> 
> Yuval, I used the same KERN_<LEVEL> output types, but it is unusual
> that DP_INFO outputs at KERN_NOTICE.
> 
> Was that a copy/paste defect or should it be emitted at KERN_INFO and
> DP_VERBOSE be emitted at KERN_DEBUG?

I agree it's a bit odd, but it's actually by design - 
as none of these prints would ever be reached unless user explicitly enable
them [ethtool/module param], the assumption is that NOTICE is good
enough, i.e., it will prevent the need for doing additional configuration of
logging levels by the user.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] qed: Add and use specific logging functions to reduce object size Joe Perches <joe@perches.com> - 2016-07-26 23:30 +0200
  Re: [PATCH] qed: Add and use specific logging functions to reduce  object size Joe Perches <joe@perches.com> - 2016-07-27 03:30 +0200
    RE: [PATCH] qed: Add and use specific logging functions to reduce  object size Yuval Mintz <Yuval.Mintz@qlogic.com> - 2016-07-27 11:40 +0200
  RE: [PATCH] qed: Add and use specific logging functions to reduce  object size Yuval Mintz <Yuval.Mintz@qlogic.com> - 2016-07-27 11:00 +0200
    Re: [PATCH] qed: Add and use specific logging functions to reduce  object size Joe Perches <joe@perches.com> - 2016-07-31 20:10 +0200
  Re: [PATCH] qed: Add and use specific logging functions to reduce  object size kbuild test robot <lkp@intel.com> - 2016-07-31 02:20 +0200

csiph-web