Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1450987
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] qed: Add and use specific logging functions to reduce object size |
| Date | 2016-07-27 03:30 +0200 |
| Message-ID | <rZlPA-1a1-3@gated-at.bofh.it> (permalink) |
| References | <rZi5j-7eZ-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 2016-07-26 at 14:25 -0700, Joe Perches wrote:
> Current DP_ macros generate a lot of code.
> Using functions with vsprintf extension %pV helps reduce that size.
Yuval, I used the same KERN_<LEVEL> output types, but it
is unusual that DP_INFO outputs at KERN_NOTICE.
Was that a copy/paste defect or should it be emitted at
KERN_INFO and DP_VERBOSE be emitted at KERN_DEBUG?
> define DP_INFO(cdev, fmt, ...) \
> - do { \
> - if (unlikely((cdev)->dp_level <= QED_LEVEL_INFO)) { \
> - pr_notice("[%s:%d(%s)]" fmt, \
> - __func__, __LINE__, \
> - DP_NAME(cdev) ? DP_NAME(cdev) : "", \
> - ## __VA_ARGS__); \
> - } \
> - } while (0)
[]
> -#define DP_VERBOSE(cdev, module, fmt, ...) \
> - do { \
> - if (unlikely(((cdev)->dp_level <= QED_LEVEL_VERBOSE) && \
> - ((cdev)->dp_module & module))) { \
> - pr_notice("[%s:%d(%s)]" fmt, \
> - __func__, __LINE__, \
> - DP_NAME(cdev) ? DP_NAME(cdev) : "", \
> - ## __VA_ARGS__); \
> - } \
> - } while (0)
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] qed: Add and use specific logging functions to reduce object size Joe Perches <joe@perches.com> - 2016-07-26 23:30 +0200
Re: [PATCH] qed: Add and use specific logging functions to reduce object size Joe Perches <joe@perches.com> - 2016-07-27 03:30 +0200
RE: [PATCH] qed: Add and use specific logging functions to reduce object size Yuval Mintz <Yuval.Mintz@qlogic.com> - 2016-07-27 11:40 +0200
RE: [PATCH] qed: Add and use specific logging functions to reduce object size Yuval Mintz <Yuval.Mintz@qlogic.com> - 2016-07-27 11:00 +0200
Re: [PATCH] qed: Add and use specific logging functions to reduce object size Joe Perches <joe@perches.com> - 2016-07-31 20:10 +0200
Re: [PATCH] qed: Add and use specific logging functions to reduce object size kbuild test robot <lkp@intel.com> - 2016-07-31 02:20 +0200
csiph-web