Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1451012

Re: [PATCH 3/4] x86/ioapic: Fix lost ioapic resource after hot-removal and hotadd

From Rui Wang <rui.y.wang@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH 3/4] x86/ioapic: Fix lost ioapic resource after hot-removal and hotadd
Date 2016-07-27 05:00 +0200
Message-ID <rZneF-22x-5@gated-at.bofh.it> (permalink)
References <rZh9g-6Gn-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, July 27, 2016 4:24 AM, Bjorn Helgaas wrote:
> On Wed, Jul 27, 2016 at 12:13:16AM +0800, Rui Wang wrote:
> > ioapic resource at 0xfecxxxxx gets lost from /proc/iomem after
> > hot-removing and then hot-adding the ioapic devices.
> >
> > After system boot, in /proc/iomem:
> > fec00000-fecfffff : PNP0003:00
> >   fec00000-fec003ff : IOAPIC 0
> >   fec01000-fec013ff : IOAPIC 1
> >   fec40000-fec403ff : IOAPIC 2
> >   fec80000-fec803ff : IOAPIC 3
> >   fecc0000-fecc03ff : IOAPIC 4
> >
> > Then hot-remove IOAPIC 2 and hot-add it again:
> > fec00000-fecfffff : PNP0003:00
> >   fec00000-fec003ff : IOAPIC 0
> >   fec01000-fec013ff : IOAPIC 1
> >   fec80000-fec803ff : IOAPIC 3
> >   fecc0000-fecc03ff : IOAPIC 4
> >
> > The range at 0xfec40000 is lost from /proc/iomem. It is because
> > handle_ioapic_add() requests resource from either PCI config BAR or
> > acpi _CRS, not both. But Intel platforms map the IOxAPIC registers
> 
> s/acpi/ACPI/
> s/ioapic/IOAPIC/ throughout
> 
> > at both the PCI config BAR (called MBAR) and the 0xfecX_YZ00 to
> > 0xfecX_Y2FF range (called ABAR). Both of the ranges should be claimed
> 
> I guess you mean the 0xfecX_YZ00-0xfecX_Y2FF range appears in _CRS?

Yes. That range appears in _CRS for each IOAPIC. I'll make it cleaner in
the commit message.

Thanks
Rui

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] Fixing a set of bugs for ioapic hotplug Rui Wang <rui.y.wang@intel.com> - 2016-07-26 18:40 +0200
  [PATCH 2/4] x86/ioapic: Fix setup_res() failing to get resource Rui Wang <rui.y.wang@intel.com> - 2016-07-26 18:40 +0200
    Re: [PATCH 2/4] x86/ioapic: Fix setup_res() failing to get resource Bjorn Helgaas <helgaas@kernel.org> - 2016-07-26 22:30 +0200
  [PATCH 3/4] x86/ioapic: Fix lost ioapic resource after hot-removal and hotadd Rui Wang <rui.y.wang@intel.com> - 2016-07-26 18:40 +0200
    Re: [PATCH 3/4] x86/ioapic: Fix lost ioapic resource after  hot-removal and hotadd kbuild test robot <lkp@intel.com> - 2016-07-26 19:00 +0200
    Re: [PATCH 3/4] x86/ioapic: Fix lost ioapic resource after  hot-removal and hotadd Bjorn Helgaas <helgaas@kernel.org> - 2016-07-26 22:30 +0200
      Re: [PATCH 3/4] x86/ioapic: Fix lost ioapic resource after hot-removal and hotadd Rui Wang <rui.y.wang@intel.com> - 2016-07-27 05:00 +0200

csiph-web