Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1450854
| From | Bjorn Helgaas <helgaas@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/4] x86/ioapic: Fix setup_res() failing to get resource |
| Date | 2016-07-26 22:30 +0200 |
| Message-ID | <rZh9g-6Gn-9@gated-at.bofh.it> (permalink) |
| References | <rZdoZ-4i9-15@gated-at.bofh.it> <rZdyG-4lo-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Jul 27, 2016 at 12:13:15AM +0800, Rui Wang wrote:
> setup_res() doesn't actually get any resoure because it mistakenly
s/resoure/resource/
> checks the return value of acpi_dev_filter_resource_type(), which
> returns 0 on success, and 1 on failure. Fix it by taking the return
> value of non-zero as failing to match the specified resource type.
>
> Signed-off-by: Rui Wang <rui.y.wang@intel.com>
> ---
> drivers/acpi/ioapic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/ioapic.c b/drivers/acpi/ioapic.c
> index 0f272e2..daf4a40 100644
> --- a/drivers/acpi/ioapic.c
> +++ b/drivers/acpi/ioapic.c
> @@ -46,7 +46,7 @@ static acpi_status setup_res(struct acpi_resource *acpi_res, void *data)
> struct resource_win win;
>
> res->flags = 0;
> - if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM) == 0)
> + if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM))
> return AE_OK;
>
> if (!acpi_dev_resource_memory(acpi_res, res)) {
> --
> 1.8.3.1
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] Fixing a set of bugs for ioapic hotplug Rui Wang <rui.y.wang@intel.com> - 2016-07-26 18:40 +0200
[PATCH 2/4] x86/ioapic: Fix setup_res() failing to get resource Rui Wang <rui.y.wang@intel.com> - 2016-07-26 18:40 +0200
Re: [PATCH 2/4] x86/ioapic: Fix setup_res() failing to get resource Bjorn Helgaas <helgaas@kernel.org> - 2016-07-26 22:30 +0200
[PATCH 3/4] x86/ioapic: Fix lost ioapic resource after hot-removal and hotadd Rui Wang <rui.y.wang@intel.com> - 2016-07-26 18:40 +0200
Re: [PATCH 3/4] x86/ioapic: Fix lost ioapic resource after hot-removal and hotadd kbuild test robot <lkp@intel.com> - 2016-07-26 19:00 +0200
Re: [PATCH 3/4] x86/ioapic: Fix lost ioapic resource after hot-removal and hotadd Bjorn Helgaas <helgaas@kernel.org> - 2016-07-26 22:30 +0200
Re: [PATCH 3/4] x86/ioapic: Fix lost ioapic resource after hot-removal and hotadd Rui Wang <rui.y.wang@intel.com> - 2016-07-27 05:00 +0200
csiph-web