Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table"

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table"
Date	2016-07-26 21:20 +0200
Message-ID	<rZg3v-616-25@gated-at.bofh.it> (permalink)
References	<rZeXL-5o9-7@gated-at.bofh.it> <rZfKa-5Fs-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jul 26, 2016 at 1:50 PM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> On Tue, Jul 26, 2016 at 01:01:32PM -0500, Rob Herring wrote:
>> This partially reverts commit 69d99e6c0d62 keeping only the main
>> purpose of the original commit which is the removal of
>> of_platform_populate() call. The moving of of_clk_init() caused changes
>> in the initialization order breaking booting.
>>
>> Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate with default match table")
>> Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> Cc: Max Filippov <jcmvbkbc@gmail.com>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> This is on top of Guenter's build fix. Please test and I'll apply. I
>
> Tested-by: Max Filippov <jcmvbkbc@gmail.com>

Thanks.

>> tried briefly running under QEMU, but didn't have success. If anyone has
>> up to date instructions that would be helpful as using these[1] didn't
>> seem to work.
>
> I think they're up to date. Another thing that need to be done right is
> the toolchain: it must match the configured CPU core. Please refer to
>   http://wiki.linux-xtensa.org/index.php/Toolchain_Overlay_File
> for more details.

I don't build toolchains...

Rob

Thread

[PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table" Rob Herring <robh@kernel.org> - 2016-07-26 20:10 +0200
  Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary  of_platform_populate with default match table" Max Filippov <jcmvbkbc@gmail.com> - 2016-07-26 21:00 +0200
    Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary  of_platform_populate with default match table" Rob Herring <robh@kernel.org> - 2016-07-26 21:20 +0200
      Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary  of_platform_populate with default match table" Max Filippov <jcmvbkbc@gmail.com> - 2016-07-26 21:50 +0200
    Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary  of_platform_populate with default match table" Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-07-27 09:00 +0200

csiph-web