Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1450792

Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table"

Show all headers | View raw

On Tue, Jul 26, 2016 at 01:01:32PM -0500, Rob Herring wrote:
> This partially reverts commit 69d99e6c0d62 keeping only the main
> purpose of the original commit which is the removal of
> of_platform_populate() call. The moving of of_clk_init() caused changes
> in the initialization order breaking booting.
> 
> Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate with default match table")
> Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> This is on top of Guenter's build fix. Please test and I'll apply. I 

Tested-by: Max Filippov <jcmvbkbc@gmail.com>

> tried briefly running under QEMU, but didn't have success. If anyone has 
> up to date instructions that would be helpful as using these[1] didn't 
> seem to work.

I think they're up to date. Another thing that need to be done right is
the toolchain: it must match the configured CPU core. Please refer to
  http://wiki.linux-xtensa.org/index.php/Toolchain_Overlay_File
for more details.

> 
> [1] http://wiki.linux-xtensa.org/index.php/Xtensa_on_QEMU
> 
>  arch/xtensa/kernel/setup.c | 9 +++++++++
>  arch/xtensa/kernel/time.c  | 2 --
>  2 files changed, 9 insertions(+), 2 deletions(-)

-- 
Thanks.
-- Max

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table" Rob Herring <robh@kernel.org> - 2016-07-26 20:10 +0200
  Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary  of_platform_populate with default match table" Max Filippov <jcmvbkbc@gmail.com> - 2016-07-26 21:00 +0200
    Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary  of_platform_populate with default match table" Rob Herring <robh@kernel.org> - 2016-07-26 21:20 +0200
      Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary  of_platform_populate with default match table" Max Filippov <jcmvbkbc@gmail.com> - 2016-07-26 21:50 +0200
    Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary  of_platform_populate with default match table" Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-07-27 09:00 +0200

csiph-web