Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1452071

Re: [PATCH] PM-wakeup: Delete unnecessary checks before three function calls

From Pavel Machek <pavel@ucw.cz>
Newsgroups linux.kernel
Subject Re: [PATCH] PM-wakeup: Delete unnecessary checks before three function calls
Date 2016-07-28 21:40 +0200
Message-ID <rZZjX-2cG-17@gated-at.bofh.it> (permalink)
References <mSsDN-4wa-35@gated-at.bofh.it> <rXQut-2Qh-1@gated-at.bofh.it> <rXXPk-7o1-3@gated-at.bofh.it> <rY44u-2Gq-13@gated-at.bofh.it> <rY6SC-4me-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat 2016-07-23 17:14:00, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 23 Jul 2016 17:04:00 +0200
> 
> The following functions test whether their argument is NULL
> and then return immediately.
> * dev_pm_arm_wake_irq
> * dev_pm_disarm_wake_irq
> * wakeup_source_unregister
> 
> Thus the test around the calls is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] PM-wakeup: Delete unnecessary checks before three  function calls Pavel Machek <pavel@ucw.cz> - 2016-07-28 21:40 +0200

csiph-web