Re: [PATCH 1/3] IB/mthca: Delete an unnecessary check before the function call "pci_dev_put"

From	Leon Romanovsky <leon@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] IB/mthca: Delete an unnecessary check before the function call "pci_dev_put"
Date	2016-07-25 15:20 +0200
Message-ID	<rYNXz-51i-1@gated-at.bofh.it> (permalink)
References	(5 earlier) <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <ooiaS-85H-29@gated-at.bofh.it> <rY2OZ-1Mx-3@gated-at.bofh.it> <rY2OZ-1Mx-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sat, Jul 23, 2016 at 12:58:08PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 23 Jul 2016 10:05:12 +0200
> 
> The pci_dev_put() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] IB/mthca: Delete an unnecessary check before the function  call "pci_dev_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-23 13:00 +0200
  Re: [PATCH 1/3] IB/mthca: Delete an unnecessary check before the  function call "pci_dev_put" Leon Romanovsky <leon@kernel.org> - 2016-07-25 15:20 +0200

csiph-web