[PATCH 1/3] IB/mthca: Delete an unnecessary check before the function call "pci_dev_put"

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH 1/3] IB/mthca: Delete an unnecessary check before the function call "pci_dev_put"
Date	2016-07-23 13:00 +0200
Message-ID	<rY2OZ-1Mx-1@gated-at.bofh.it> (permalink)
References	(14 earlier) <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <ooiaS-85H-29@gated-at.bofh.it> <rY2OZ-1Mx-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 23 Jul 2016 10:05:12 +0200

The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/infiniband/hw/mthca/mthca_reset.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/mthca/mthca_reset.c b/drivers/infiniband/hw/mthca/mthca_reset.c
index 74c6a94..c521654 100644
--- a/drivers/infiniband/hw/mthca/mthca_reset.c
+++ b/drivers/infiniband/hw/mthca/mthca_reset.c
@@ -279,8 +279,7 @@ good:
 	}
 
 out:
-	if (bridge)
-		pci_dev_put(bridge);
+	pci_dev_put(bridge);
 	kfree(bridge_header);
 	kfree(hca_header);
 
-- 
2.9.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] IB/mthca: Delete an unnecessary check before the function  call "pci_dev_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-23 13:00 +0200
  Re: [PATCH 1/3] IB/mthca: Delete an unnecessary check before the  function call "pci_dev_put" Leon Romanovsky <leon@kernel.org> - 2016-07-25 15:20 +0200

csiph-web