Re: [PATCH v2 2/9] hwmon: (core) New hwmon registration API

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/9] hwmon: (core) New hwmon registration API
Date	2016-07-25 05:00 +0200
Message-ID	<rYEhz-7rb-1@gated-at.bofh.it> (permalink)
References	<rVMY1-5d7-1@gated-at.bofh.it> <rVMY2-5d7-19@gated-at.bofh.it> <rYwWK-3ef-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/24/2016 12:08 PM, Jonathan Cameron wrote:
> On 17/07/16 06:30, Guenter Roeck wrote:
>> Up to now, each hwmon driver has to implement its own sysfs attributes.
>> This requires a lot of template code, and distracts from the driver's core
>> function to read and write chip registers.
>>
>> To be able to reduce driver complexity, move sensor attribute handling
>> and thermal zone registration into hwmon core. By using the new API,
>> driver code and data size is typically reduced by 20-70%, depending
>> on driver complexity and the number of sysfs attributes supported.
>>
>> With this patch, the new API only supports thermal sensors. Support for
>> other sensor types will be added with subsequent patches.
>>
> Looks good to me which is pretty unusual for a V2 of anything ;)
>

Thanks ... unfortunately, it wasn't perfect, so I'll have to send another version.
The thermal code needs to be surrounded with "#if IS_REACHABLE(CONFIG_THERMAL)
&& defined(CONFIG_THERMAL_OF)".

Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/9] hwmon: New hwmon registration API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
  [PATCH v2 7/9] hwmon: (core) Add fan attribute support to new API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
  [PATCH v2 8/9] hwmon: (core) Document new kernel API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
    Re: [PATCH v2 8/9] hwmon: (core) Document new kernel API Jonathan Cameron <jic23@kernel.org> - 2016-07-24 21:20 +0200
  [PATCH v2 1/9] hwmon: (core) Order include files alphabetically Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
  [PATCH v2 5/9] hwmon: (core) Add power attribute support to new API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
  [PATCH v2 9/9] hwmon: (core) Add basic pwm attribute support to new API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
  [PATCH v2 3/9] hwmon: (core) Add voltage attribute support to new API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
  [PATCH v2 6/9] hwmon: (core) Add energy and humidity attribute support to new API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
  [PATCH v2 4/9] hwmon: (core) Add current attribute support to new API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
  [PATCH v2 2/9] hwmon: (core) New hwmon registration API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
    Re: [PATCH v2 2/9] hwmon: (core) New hwmon registration API Jonathan Cameron <jic23@kernel.org> - 2016-07-24 21:10 +0200
      Re: [PATCH v2 2/9] hwmon: (core) New hwmon registration API Guenter Roeck <linux@roeck-us.net> - 2016-07-25 05:00 +0200

csiph-web