Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1445017

[PATCH v2 0/9] hwmon: New hwmon registration API

Show all headers | View raw

Up to now, each hwmon driver has to implement its own sysfs attributes.
This requires a lot of template code, and distracts from the driver's
core function to read and write chip registers.

To be able to reduce driver complexity, move sensor attribute handling
and thermal zone registration into the hwmon core. By using the new API,
driver size is typically reduced by 20-50% depending on driver complexity
and the number of sysfs attributes supported.

The first patch of the series is preparatory; it reorders include files
in the hwmon core to make it easier to add or remove individual include
files.

The secind patch of the series introduces the API as well as support
for temperature sensor attributes. Subsequent patches introduce support
for voltage, current, power, energy, humidity, fan speed, and basic pwm
attributes.

The series was tested by converting several drivers (lm75, lm90, tmp102,
tmp421, ltc4245, nct7904, max31790) to the new API. Testing was done with
real chips as well as with the hwmon driver module test code available
at https://github.com/groeck/module-tests.

v2:
- Add patch 1/9 (order include files alphabetically).
- Add patch 9/9 (pwm support).
- Document callback function parameters of struct hwmon_ops in
  include/linux/hwmon.h.
- Clarify that the is_visible() callback is mandatory.
- If an attribute has no template string, treat it as invisible, not as
  error. Affected are virtual attributes such as HWMON_C_REGISTER_TZ.
- Initialize device attribute read/write callback functions unconditionally.
- Cosmetic changes, including typo fixes and added newlines for readability.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/9] hwmon: New hwmon registration API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
  [PATCH v2 7/9] hwmon: (core) Add fan attribute support to new API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
  [PATCH v2 8/9] hwmon: (core) Document new kernel API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
    Re: [PATCH v2 8/9] hwmon: (core) Document new kernel API Jonathan Cameron <jic23@kernel.org> - 2016-07-24 21:20 +0200
  [PATCH v2 1/9] hwmon: (core) Order include files alphabetically Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
  [PATCH v2 5/9] hwmon: (core) Add power attribute support to new API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
  [PATCH v2 9/9] hwmon: (core) Add basic pwm attribute support to new API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
  [PATCH v2 3/9] hwmon: (core) Add voltage attribute support to new API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
  [PATCH v2 6/9] hwmon: (core) Add energy and humidity attribute support to new API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
  [PATCH v2 4/9] hwmon: (core) Add current attribute support to new API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
  [PATCH v2 2/9] hwmon: (core) New hwmon registration API Guenter Roeck <linux@roeck-us.net> - 2016-07-17 07:40 +0200
    Re: [PATCH v2 2/9] hwmon: (core) New hwmon registration API Jonathan Cameron <jic23@kernel.org> - 2016-07-24 21:10 +0200
      Re: [PATCH v2 2/9] hwmon: (core) New hwmon registration API Guenter Roeck <linux@roeck-us.net> - 2016-07-25 05:00 +0200

csiph-web