Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1449237
| From | Tan Xiaojun <tanxiaojun@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver |
| Date | 2016-07-25 04:20 +0200 |
| Message-ID | <rYDER-7eV-1@gated-at.bofh.it> (permalink) |
| References | <rXEjD-3pq-1@gated-at.bofh.it> <rXGls-4Jg-9@gated-at.bofh.it> <rXIQi-6tq-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2016/7/22 21:27, Arnd Bergmann wrote: > On Friday, July 22, 2016 11:56:49 AM CEST Mark Rutland wrote: >> Hi, >> >> I understand that some SoC/socket level PMU is accessed via these >> registers. It doesn't make sense to review either in isolation. Please >> put together a unified series, with both the djtag accessors and the >> PMU code. >> >> On it's own, it's *very* difficult to understand how this fits into the >> SoC, and how it is to be used. > > Is there anything else that the driver is used for? > > Having it in drivers/soc/ feels wrong to me, and if there is only > one user, I'd recommend having it as part of the same driver module > as the code accessing it. > > Arnd > Many modules will use it, and they are waiting for djtag upstream. Maybe it should not have been presented separately. I will think about it. Thanks, Xiaojun. > > . >
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH v1 0/2] Add Hisilicon Djtag driver Tan Xiaojun <tanxiaojun@huawei.com> - 2016-07-22 10:50 +0200
[RFC PATCH v1 1/2] Documentation: arm64: Add Hisilicon HiP05/06/07 Sysctrl and Djtag dts bindings Tan Xiaojun <tanxiaojun@huawei.com> - 2016-07-22 10:50 +0200
[RFC PATCH v1 2/2] drivers: soc: Add support for Hisilicon Djtag driver Tan Xiaojun <tanxiaojun@huawei.com> - 2016-07-22 10:50 +0200
Re: [RFC PATCH v1 2/2] drivers: soc: Add support for Hisilicon Djtag driver Paul Gortmaker <paul.gortmaker@gmail.com> - 2016-07-22 22:40 +0200
Re: [RFC PATCH v1 2/2] drivers: soc: Add support for Hisilicon Djtag driver Tan Xiaojun <tanxiaojun@huawei.com> - 2016-07-25 04:00 +0200
Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver Mark Rutland <mark.rutland@arm.com> - 2016-07-22 13:00 +0200
Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver Arnd Bergmann <arnd@arndb.de> - 2016-07-22 15:40 +0200
Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver Tan Xiaojun <tanxiaojun@huawei.com> - 2016-07-25 04:20 +0200
Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver Tan Xiaojun <tanxiaojun@huawei.com> - 2016-07-25 04:10 +0200
csiph-web