Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1448535

Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver

Show all headers | View raw

Hi,

I understand that some SoC/socket level PMU is accessed via these
registers. It doesn't make sense to review either in isolation. Please
put together a unified series, with both the djtag accessors and the
PMU code.

On it's own, it's *very* difficult to understand how this fits into the
SoC, and how it is to be used.

Thanks,
Mark.

On Fri, Jul 22, 2016 at 04:48:50PM +0800, Tan Xiaojun wrote:
> 
> Tan Xiaojun (2):
>   Documentation: arm64: Add Hisilicon HiP05/06/07 Sysctrl and Djtag dts
>     bindings
>   drivers: soc: Add support for Hisilicon Djtag driver
> 
>  .../bindings/arm/hisilicon/hisilicon.txt           |   98 +++++
>  drivers/soc/Kconfig                                |    1 +
>  drivers/soc/Makefile                               |    1 +
>  drivers/soc/hisilicon/Kconfig                      |   12 +
>  drivers/soc/hisilicon/Makefile                     |    1 +
>  drivers/soc/hisilicon/djtag.c                      |  373 ++++++++++++++++++++
>  include/linux/soc/hisilicon/djtag.h                |   18 +
>  7 files changed, 504 insertions(+)
>  create mode 100644 drivers/soc/hisilicon/Kconfig
>  create mode 100644 drivers/soc/hisilicon/Makefile
>  create mode 100644 drivers/soc/hisilicon/djtag.c
>  create mode 100644 include/linux/soc/hisilicon/djtag.h
> 
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v1 0/2] Add Hisilicon Djtag driver Tan Xiaojun <tanxiaojun@huawei.com> - 2016-07-22 10:50 +0200
  [RFC PATCH v1 1/2] Documentation: arm64: Add Hisilicon HiP05/06/07 Sysctrl and Djtag dts bindings Tan Xiaojun <tanxiaojun@huawei.com> - 2016-07-22 10:50 +0200
  [RFC PATCH v1 2/2] drivers: soc: Add support for Hisilicon Djtag driver Tan Xiaojun <tanxiaojun@huawei.com> - 2016-07-22 10:50 +0200
    Re: [RFC PATCH v1 2/2] drivers: soc: Add support for Hisilicon Djtag driver Paul Gortmaker <paul.gortmaker@gmail.com> - 2016-07-22 22:40 +0200
      Re: [RFC PATCH v1 2/2] drivers: soc: Add support for Hisilicon Djtag  driver Tan Xiaojun <tanxiaojun@huawei.com> - 2016-07-25 04:00 +0200
  Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver Mark Rutland <mark.rutland@arm.com> - 2016-07-22 13:00 +0200
    Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver Arnd Bergmann <arnd@arndb.de> - 2016-07-22 15:40 +0200
      Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver Tan Xiaojun <tanxiaojun@huawei.com> - 2016-07-25 04:20 +0200
    Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver Tan Xiaojun <tanxiaojun@huawei.com> - 2016-07-25 04:10 +0200

csiph-web