Re: [PATCH] x86/boot: Reorganize and clean up the BIOS area reservation code

From	Andy Lutomirski <luto@amacapital.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/boot: Reorganize and clean up the BIOS area reservation code
Date	2016-07-21 23:10 +0200
Message-ID	<rXtoe-4vY-5@gated-at.bofh.it> (permalink)
References	<rXb7X-Jj-1@gated-at.bofh.it> <rXhn4-4Uk-21@gated-at.bofh.it> <rXnCa-kD-33@gated-at.bofh.it> <rXoRz-1m6-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jul 21, 2016 at 9:18 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Andy Lutomirski <luto@amacapital.net> wrote:
>
>> It would be very easy to implement this if we could handle overlapping memblocks
>> precisely or set a lower limit on the memblock allocator. Then we could block
>> off everything below 1MB or 2MB very early and then unblock it or temporarily
>> change the lower limit and ask for a single page for the trampoline after that.
>
> So my suggestion was/is to _permanently_ allocate the SMP trampoline page, and
> leave it also reserved.
>
> 'Reserving' a memory area is really just a kernel internal matter. We can still
> use it. No need to unreserve/allocate/re-reserve ... unless I'm missing something.
>

I don't think you're missing anything particularly deep.  I'm just
talking about an implementation issue.  We need to make sure that the
page we pick for the trampoline isn't reserved in the memory map or by
some other quirk (including the EBDA).  The kernel currently uses
memblock for this, which means that we should probably play nicely
with the memblock code.

To fix my laptop, though, I think we either need to change the EBDA
reservation (i.e. be willing to pick a page above the EBDA but below
the BIOS) or rework the code so that it can use a BOOT_SERVICES_DATA
page.

--Andy

Thread

[PATCH] x86/ebda: If the EBDA is in lowmem, reserve only 4k for the EBDA Andy Lutomirski <luto@kernel.org> - 2016-07-21 03:40 +0200
  [PATCH] x86/boot: Reorganize and clean up the BIOS area reservation  code Ingo Molnar <mingo@kernel.org> - 2016-07-21 10:20 +0200
    Re: [PATCH] x86/boot: Reorganize and clean up the BIOS area  reservation code Ingo Molnar <mingo@kernel.org> - 2016-07-21 10:40 +0200
    Re: [PATCH] x86/boot: Reorganize and clean up the BIOS area reservation code "H. Peter Anvin" <hpa@zytor.com> - 2016-07-21 10:40 +0200
      Re: [PATCH] x86/boot: Reorganize and clean up the BIOS area  reservation code Ingo Molnar <mingo@kernel.org> - 2016-07-21 11:20 +0200
      Re: [PATCH] x86/boot: Reorganize and clean up the BIOS area  reservation code Ingo Molnar <mingo@kernel.org> - 2016-07-21 11:20 +0200
        Re: [PATCH] x86/boot: Reorganize and clean up the BIOS area reservation code "H. Peter Anvin" <hpa@zytor.com> - 2016-07-21 14:40 +0200
    Re: [PATCH] x86/boot: Reorganize and clean up the BIOS area  reservation code Andy Lutomirski <luto@amacapital.net> - 2016-07-21 17:00 +0200
      Re: [PATCH] x86/boot: Reorganize and clean up the BIOS area  reservation code Ingo Molnar <mingo@kernel.org> - 2016-07-21 18:20 +0200
        Re: [PATCH] x86/boot: Reorganize and clean up the BIOS area  reservation code Andy Lutomirski <luto@amacapital.net> - 2016-07-21 23:10 +0200
          Re: [PATCH] x86/boot: Reorganize and clean up the BIOS area reservation code "H. Peter Anvin" <hpa@zytor.com> - 2016-07-21 23:30 +0200
            Re: [PATCH] x86/boot: Reorganize and clean up the BIOS area  reservation code Andy Lutomirski <luto@amacapital.net> - 2016-07-21 23:50 +0200
              Re: [PATCH] x86/boot: Reorganize and clean up the BIOS area  reservation code Andy Lutomirski <luto@amacapital.net> - 2016-07-22 00:50 +0200
                Re: [PATCH] x86/boot: Reorganize and clean up the BIOS area  reservation code Matt Fleming <matt@codeblueprint.co.uk> - 2016-07-22 15:10 +0200
                Re: [PATCH] x86/boot: Reorganize and clean up the BIOS area  reservation code Linus Torvalds <torvalds@linux-foundation.org> - 2016-07-23 03:20 +0200

csiph-web