[PATCH v4 2/7] drm/nouveau/core: make use of new strlcpytolower() function

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Markus Mayer <mmayer@broadcom.com>
Newsgroups	linux.kernel
Subject	[PATCH v4 2/7] drm/nouveau/core: make use of new strlcpytolower() function
Date	Sat, 23 Jul 2016 01:40:01 +0200
Message-ID	<rXScV-3Uh-29@gated-at.bofh.it> (permalink)
References	<rXScV-3Uh-5@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=i4jZ0Vnget3MB6Z8w51ZHWxZW22NB0XBdDNT/R4TWM4=; b=MK5KgBGsicbDt3gdMBJD6kOXbqi4noeLKh0ghXvT7v8pg/AGPlaFnVhINdQGt0W7yg HqSKzkwwyzJXZqETqSnRvHtEkRUniVVTxCFDV63x6YxAstTU3iVcMBo0EVEsXpQ1HfPC OH9gDhdHiwTumO9Z3ro3nNS48z8d9HUv2/EHs=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=i4jZ0Vnget3MB6Z8w51ZHWxZW22NB0XBdDNT/R4TWM4=; b=b0RDad8xV7lAwoQDoUo1bs+DVxwaRuiKH6kgNBhQ6TIDNrvnm9lc3EuHR3ChqaPRKR fQTfAOItPGLZUgLuBVoyKjDTnV/FSNSI0xkuIMH//TTi5BuIf2B9bXhp3GZAmNJ4MXB4 8zfeA58Lyr1nv7pucQpjnryaDwM6nXSJNK8ElbLTfzv9AmTyFAw49VdI0ax9XJlK3Nqg Qs64B6w6bpu2M7TebRBL9Aoi72ZUhPfx56VbhLOmmxLuYl243n7O9TsszVy603HNDPUf 7aaT/yc0iqlw1xQS5/tlD5W4W8fmjYb38AYL90nMoie2s5OZUxKZDyFXmlN/wpTYRfKF Nldw==
X-Gm-Message-State	AEkoouvXo73IA5ZoF3HzKzMMZNLbDhfFtC3iiAptU4v2fAYIob4xeu6QiEzg4lfByLEDZi90
X-Received	by 10.55.98.205 with SMTP id w196mr7921412qkb.65.1469230355682; Fri, 22 Jul 2016 16:32:35 -0700 (PDT)
X-Mailer	git-send-email 2.7.4
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	Markus Mayer <mmayer@broadcom.com>, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 22 Jul 2016 16:31:04 -0700
X-Original-Message-ID	<1469230269-1644-3-git-send-email-mmayer@broadcom.com>
X-Original-References	<1469230269-1644-1-git-send-email-mmayer@broadcom.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1448837

Show key headers only | View raw

Call strlcpytolower() rather than copying the string explicitly and
then walking it to convert it to lowercase.

Signed-off-by: Markus Mayer <mmayer@broadcom.com>
---

The semantics of the new function has changed, so this patch has been
updated since v2 to match the new strlcpy() semantics (no explicit NULL
terminating is required).

See https://patchwork.kernel.org/patch/9215207/ for the previous version.

 drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
index 34ecd4a..982601e 100644
--- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
+++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
@@ -36,16 +36,9 @@ nvkm_firmware_get(struct nvkm_device *device, const char *fwname,
 {
 	char f[64];
 	char cname[16];
-	int i;
 
 	/* Convert device name to lowercase */
-	strncpy(cname, device->chip->name, sizeof(cname));
-	cname[sizeof(cname) - 1] = '\0';
-	i = strlen(cname);
-	while (i) {
-		--i;
-		cname[i] = tolower(cname[i]);
-	}
+	strlcpytolower(cname, device->chip->name, sizeof(cname));
 
 	snprintf(f, sizeof(f), "nvidia/%s/%s.bin", cname, fwname);
 	return request_firmware(fw, f, device->dev);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/7] lib: string: add functions to case-convert strings Markus Mayer <mmayer@broadcom.com> - 2016-07-23 01:40 +0200
  [PATCH v4 4/7] staging: speakup: replace spk_strlwr() with strlcpytolower() Markus Mayer <mmayer@broadcom.com> - 2016-07-23 01:40 +0200
    Re: [PATCH v4 4/7] staging: speakup: replace spk_strlwr() with strlcpytolower() Chris Brannon <chris@the-brannons.com> - 2016-07-23 02:10 +0200
  [PATCH v4 1/7] lib: string: add functions to case-convert strings Markus Mayer <mmayer@broadcom.com> - 2016-07-23 01:40 +0200
  [PATCH v4 3/7] ACPI / device_sysfs: make use of new strtolower() function Markus Mayer <mmayer@broadcom.com> - 2016-07-23 01:40 +0200
  [PATCH v4 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower() Markus Mayer <mmayer@broadcom.com> - 2016-07-23 01:40 +0200
  [PATCH v4 2/7] drm/nouveau/core: make use of new strlcpytolower() function Markus Mayer <mmayer@broadcom.com> - 2016-07-23 01:40 +0200

csiph-web