Path: csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod From: Markus Mayer Newsgroups: linux.kernel Subject: [PATCH v4 2/7] drm/nouveau/core: make use of new strlcpytolower() function Date: Sat, 23 Jul 2016 01:40:01 +0200 Message-ID: References: Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=i4jZ0Vnget3MB6Z8w51ZHWxZW22NB0XBdDNT/R4TWM4=; b=MK5KgBGsicbDt3gdMBJD6kOXbqi4noeLKh0ghXvT7v8pg/AGPlaFnVhINdQGt0W7yg HqSKzkwwyzJXZqETqSnRvHtEkRUniVVTxCFDV63x6YxAstTU3iVcMBo0EVEsXpQ1HfPC OH9gDhdHiwTumO9Z3ro3nNS48z8d9HUv2/EHs= X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=i4jZ0Vnget3MB6Z8w51ZHWxZW22NB0XBdDNT/R4TWM4=; b=b0RDad8xV7lAwoQDoUo1bs+DVxwaRuiKH6kgNBhQ6TIDNrvnm9lc3EuHR3ChqaPRKR fQTfAOItPGLZUgLuBVoyKjDTnV/FSNSI0xkuIMH//TTi5BuIf2B9bXhp3GZAmNJ4MXB4 8zfeA58Lyr1nv7pucQpjnryaDwM6nXSJNK8ElbLTfzv9AmTyFAw49VdI0ax9XJlK3Nqg Qs64B6w6bpu2M7TebRBL9Aoi72ZUhPfx56VbhLOmmxLuYl243n7O9TsszVy603HNDPUf 7aaT/yc0iqlw1xQS5/tlD5W4W8fmjYb38AYL90nMoie2s5OZUxKZDyFXmlN/wpTYRfKF Nldw== X-Gm-Message-State: AEkoouvXo73IA5ZoF3HzKzMMZNLbDhfFtC3iiAptU4v2fAYIob4xeu6QiEzg4lfByLEDZi90 X-Received: by 10.55.98.205 with SMTP id w196mr7921412qkb.65.1469230355682; Fri, 22 Jul 2016 16:32:35 -0700 (PDT) X-Mailer: git-send-email 2.7.4 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 39 Organization: linux.* mail to news gateway X-Original-Cc: Markus Mayer , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Original-Date: Fri, 22 Jul 2016 16:31:04 -0700 X-Original-Message-ID: <1469230269-1644-3-git-send-email-mmayer@broadcom.com> X-Original-References: <1469230269-1644-1-git-send-email-mmayer@broadcom.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1448837 Call strlcpytolower() rather than copying the string explicitly and then walking it to convert it to lowercase. Signed-off-by: Markus Mayer --- The semantics of the new function has changed, so this patch has been updated since v2 to match the new strlcpy() semantics (no explicit NULL terminating is required). See https://patchwork.kernel.org/patch/9215207/ for the previous version. drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c index 34ecd4a..982601e 100644 --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c @@ -36,16 +36,9 @@ nvkm_firmware_get(struct nvkm_device *device, const char *fwname, { char f[64]; char cname[16]; - int i; /* Convert device name to lowercase */ - strncpy(cname, device->chip->name, sizeof(cname)); - cname[sizeof(cname) - 1] = '\0'; - i = strlen(cname); - while (i) { - --i; - cname[i] = tolower(cname[i]); - } + strlcpytolower(cname, device->chip->name, sizeof(cname)); snprintf(f, sizeof(f), "nvidia/%s/%s.bin", cname, fwname); return request_firmware(fw, f, device->dev); -- 2.7.4