Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1448798

Re: [PATCH v2] Documentation/watchdog: check return value for magic close

Show all headers | View raw

Arnd Bergmann wrote:
> A recent commit added a write to the watchdog test code for doing the "magic
> close", but that caused a compile-time warning:
>
> Documentation/watchdog/src/watchdog-test.c: In function ‘main’:
> Documentation/watchdog/src/watchdog-test.c:94:5: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
>
> This changes the code to print a runtime warning if the write fails.
>
> Fixes: 5a2d3de19602 ("Documentation/watchdog: add support for magic close to watchdog-test")
> Signed-off-by: Arnd Bergmann<arnd@arndb.de>

Acked-by: Timur Tabi <timur@codeaurora.org>

Thanks for this patch.  I don't know why I didn't notice the warnings 
before.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] Documentation/watchdog: check return value for magic close Arnd Bergmann <arnd@arndb.de> - 2016-07-19 17:50 +0200
  Re: [PATCH v2] Documentation/watchdog: check return value for magic  close Guenter Roeck <linux@roeck-us.net> - 2016-07-20 04:00 +0200
  Re: [PATCH v2] Documentation/watchdog: check return value for magic  close Timur Tabi <timur@codeaurora.org> - 2016-07-22 23:40 +0200

csiph-web