Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1448797
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Revert "cpufreq: pcc-cpufreq: update default value of cpuinfo_transition_latency" |
| Date | 2016-07-22 23:30 +0200 |
| Message-ID | <rXQb7-2Jh-9@gated-at.bofh.it> (permalink) |
| References | <rXKp3-7uV-7@gated-at.bofh.it> <rXKIq-7Bs-15@gated-at.bofh.it> <rXQb7-2Jh-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 22-07-16, 23:31, Rafael J. Wysocki wrote:
> > cpufreq.c
> >
> > if (policy->governor->max_transition_latency &&
> > policy->cpuinfo.transition_latency >
> > policy->governor->max_transition_latency) {
> >
> > - And this check will always fail, unless max_transition_latency is zero.
>
> Why would it fail? If governor->max_transition_latency is non-zero, but less
> than UNIT_MAX, the condition checked will be true to my eyes.
Bad wording. Sorry.
I meant, this 'if' check will always succeed (as you also noted), and
so we will always get the error message reported in this patch.
cpufreq: ondemand governor failed, too long transition latency of HW,
fallback to performance governor
--
viresh
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] Revert "cpufreq: pcc-cpufreq: update default value of cpuinfo_transition_latency" Andreas Herrmann <aherrmann@suse.com> - 2016-07-22 17:20 +0200
Re: [PATCH] Revert "cpufreq: pcc-cpufreq: update default value of cpuinfo_transition_latency" Viresh Kumar <viresh.kumar@linaro.org> - 2016-07-22 17:40 +0200
Re: [PATCH] Revert "cpufreq: pcc-cpufreq: update default value of cpuinfo_transition_latency" "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-22 23:30 +0200
Re: [PATCH] Revert "cpufreq: pcc-cpufreq: update default value of cpuinfo_transition_latency" Viresh Kumar <viresh.kumar@linaro.org> - 2016-07-22 23:30 +0200
Re: [PATCH] Revert "cpufreq: pcc-cpufreq: update default value of cpuinfo_transition_latency" "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-22 23:50 +0200
Re: [PATCH] Revert "cpufreq: pcc-cpufreq: update default value of cpuinfo_transition_latency" Viresh Kumar <viresh.kumar@linaro.org> - 2016-07-23 01:40 +0200
Re: [PATCH] Revert "cpufreq: pcc-cpufreq: update default value of cpuinfo_transition_latency" "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-23 01:50 +0200
Re: [PATCH] Revert "cpufreq: pcc-cpufreq: update default value of cpuinfo_transition_latency" Viresh Kumar <viresh.kumar@linaro.org> - 2016-07-23 02:00 +0200
csiph-web