Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1445930

Is THREAD_INFO_IN_TASK appropriate for -mm for 4.8?

Show all headers | View raw

Hi all-

There are four core patches needed for the THREAD_INFO_IN_TASK thing,
and they apply cleanly to -mm now.  The x86 patch to flip the feature
on does not apply cleanly anywhere because it depends on changes in
-tip *and* in -mm.  I'd like to get all of this as well as the rest of
the vmap-stacks stuff in by 4.9, but I'm wondering if it might make
sense to get the core THREAD_INFO_IN_TASK stuff into -mm for 4.8
instead.

Pros:
 - It reduces the amount of core code that -tip will have to carry until 4.9.
 - It may benefit other architectures.  Christian Borntraeger
expressed an interest in enabling the feature for s390, but it'll be
awkward for him until the core bit landed.  Similarly, arm64 seems to
be interested.

Cons: It's a bit odd to merge code that can't be enabled as-is.  OTOH
x86 could plausibly enable it for 4.8 if Ingo is okay with applying
"x86/dumpstack: Pin the target stack in save_stack_trace_tsk()" and
"x86: Move thread_info into task_struct" during the merge window after
the -mm patchbomb lands.

The core changes are:

sched: Allow putting thread_info into task_struct
sched: Add try_get_task_stack() and put_task_stack()
kthread: to_live_kthread() needs try_get_task_stack()
sched: Free the stack early if CONFIG_THREAD_INFO_IN_TASK

They're also sitting here against mmots:

https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/log/?h=mmots_ti_in_task

It looks like this:

 include/linux/init_task.h   | 11 ++++++++
 include/linux/sched.h       | 66 +++++++++++++++++++++++++++++++++++++++++++--
 include/linux/thread_info.h | 15 +++++++++++
 init/Kconfig                | 10 +++++++
 init/init_task.c            |  7 +++--
 kernel/fork.c               | 35 +++++++++++++++++++++++-
 kernel/kthread.c            |  8 ++++--
 kernel/sched/core.c         |  4 +++
 kernel/sched/sched.h        |  4 +++
 9 files changed, 153 insertions(+), 7 deletions(-)

So... should I send it out against -mm or should I wait until 4.8-rc1.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Is THREAD_INFO_IN_TASK appropriate for -mm for 4.8? Andy Lutomirski <luto@kernel.org> - 2016-07-19 01:50 +0200
  Re: Is THREAD_INFO_IN_TASK appropriate for -mm for 4.8? Christian Borntraeger <borntraeger@de.ibm.com> - 2016-07-19 10:30 +0200
    Re: Is THREAD_INFO_IN_TASK appropriate for -mm for 4.8? Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-07-25 16:30 +0200
  Re: Is THREAD_INFO_IN_TASK appropriate for -mm for 4.8? Mark Rutland <mark.rutland@arm.com> - 2016-07-19 13:30 +0200
  Re: Is THREAD_INFO_IN_TASK appropriate for -mm for 4.8? Ingo Molnar <mingo@kernel.org> - 2016-07-20 09:50 +0200

csiph-web