Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1445894

Re: [PATCH v3 2/3] spi: of: allow instantiating slaves without a driver

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Jul 19, 2016 at 12:35:41AM +0200, Michal Suchanek wrote:
> SPI slave devices are not created when looking up driver for the slave
> fails. Create a device anyway so it can be used with spidev.

>  	rc = of_modalias_node(nc, spi->modalias,
>  				sizeof(spi->modalias));
>  	if (rc < 0) {
> -		dev_err(&master->dev, "cannot find modalias for %s\n",
> +		dev_warn(&master->dev, "cannot find modalias for %s\n",

Nothing has change since you last sent this patch which converts
of_modailias_node() into something which looks up a driver so the
patch description still fails to describe what the patch is doing.

Please don't ignore review comments, people are generally making them
for a reason and are likely to have the same concerns if issues remain
unaddressed.  Having to repeat the same comments can get repetitive and
make people question the value of time spent reviewing.  If you disagree
with the review comments that's fine but you need to reply and discuss
your concerns so that the reviewer can understand your decisions.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/3] Spidev usability patchset update Michal Suchanek <hramrach@gmail.com> - 2016-07-19 00:40 +0200
  [PATCH v3 2/3] spi: of: allow instantiating slaves without a driver Michal Suchanek <hramrach@gmail.com> - 2016-07-19 00:40 +0200
    Re: [PATCH v3 2/3] spi: of: allow instantiating slaves without a  driver Mark Brown <broonie@kernel.org> - 2016-07-19 01:10 +0200
      Re: [PATCH v3 2/3] spi: of: allow instantiating slaves without a driver Michal Suchanek <hramrach@gmail.com> - 2016-07-19 10:40 +0200
        Re: [PATCH v3 2/3] spi: of: allow instantiating slaves without a  driver Mark Brown <broonie@kernel.org> - 2016-07-19 13:00 +0200
  [PATCH v3 1/3] spi: spidev: create spidev device for all spi slaves. Michal Suchanek <hramrach@gmail.com> - 2016-07-19 00:40 +0200
    Re: [PATCH v3 1/3] spi: spidev: create spidev device for all spi  slaves. Mark Brown <broonie@kernel.org> - 2016-07-19 01:10 +0200
      Re: [PATCH v3 1/3] spi: spidev: create spidev device for all spi slaves. Michal Suchanek <hramrach@gmail.com> - 2016-07-19 13:20 +0200
        Re: [PATCH v3 1/3] spi: spidev: create spidev device for all spi  slaves. Mark Brown <broonie@kernel.org> - 2016-07-19 14:50 +0200
          Re: [PATCH v3 1/3] spi: spidev: create spidev device for all spi slaves. Michal Suchanek <hramrach@gmail.com> - 2016-07-19 17:40 +0200
            Re: [PATCH v3 1/3] spi: spidev: create spidev device for all spi  slaves. Mark Brown <broonie@kernel.org> - 2016-07-19 19:30 +0200
              Re: [PATCH v3 1/3] spi: spidev: create spidev device for all spi slaves. Michal Suchanek <hramrach@gmail.com> - 2016-07-19 20:40 +0200
    Re: [lkp] [PATCH v3 1/3] spi: spidev: create spidev device for all  spi slaves. Fengguang Wu <fengguang.wu@intel.com> - 2016-07-20 09:20 +0200
  [PATCH v3 3/3] spi: core: allow creating devices without spi-max-frequency Michal Suchanek <hramrach@gmail.com> - 2016-07-19 00:40 +0200

csiph-web