Re: [PATCH v3 2/3] spi: of: allow instantiating slaves without a driver

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/3] spi: of: allow instantiating slaves without a driver
Date	2016-07-19 13:00 +0200
Message-ID	<rWAUN-2Zq-13@gated-at.bofh.it> (permalink)
References	<rWpmF-3Qw-3@gated-at.bofh.it> <rWpmF-3Qw-13@gated-at.bofh.it> <rWpPH-4he-1@gated-at.bofh.it> <rWyJk-1Ja-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Jul 19, 2016 at 10:31:54AM +0200, Michal Suchanek wrote:
> On 19 July 2016 at 01:02, Mark Brown <broonie@kernel.org> wrote:
> > On Tue, Jul 19, 2016 at 12:35:41AM +0200, Michal Suchanek wrote:

> >> SPI slave devices are not created when looking up driver for the slave
> >> fails. Create a device anyway so it can be used with spidev.

> > Nothing has change since you last sent this patch which converts
> > of_modailias_node() into something which looks up a driver so the
> > patch description still fails to describe what the patch is doing.

> I have split the other part of the patch. Regarding the commit message
> if you have suggestion for better wording please do share it.

As covered in SubmittingPatches your commit message should describe what
the change does and what the intended effect is.  If we were looking for
a device driver the code would be looking up a struct device_driver or
some other struct that contains one.  

> From my point of view the conceptual change described in the commit message
> is that whenever SPI slave node is encountered in devicetree you get either
> a device with active driver or a device with no driver whereas
> previously you either
> got a device with active driver or no device. So yes, it's about

This is not the case, it is perfectly possible to have a device with no
driver bound to it otherwise it would not be possible to use loadable
modules for drivers.

Thread

[PATCH v3 0/3] Spidev usability patchset update Michal Suchanek <hramrach@gmail.com> - 2016-07-19 00:40 +0200
  [PATCH v3 2/3] spi: of: allow instantiating slaves without a driver Michal Suchanek <hramrach@gmail.com> - 2016-07-19 00:40 +0200
    Re: [PATCH v3 2/3] spi: of: allow instantiating slaves without a  driver Mark Brown <broonie@kernel.org> - 2016-07-19 01:10 +0200
      Re: [PATCH v3 2/3] spi: of: allow instantiating slaves without a driver Michal Suchanek <hramrach@gmail.com> - 2016-07-19 10:40 +0200
        Re: [PATCH v3 2/3] spi: of: allow instantiating slaves without a  driver Mark Brown <broonie@kernel.org> - 2016-07-19 13:00 +0200
  [PATCH v3 1/3] spi: spidev: create spidev device for all spi slaves. Michal Suchanek <hramrach@gmail.com> - 2016-07-19 00:40 +0200
    Re: [PATCH v3 1/3] spi: spidev: create spidev device for all spi  slaves. Mark Brown <broonie@kernel.org> - 2016-07-19 01:10 +0200
      Re: [PATCH v3 1/3] spi: spidev: create spidev device for all spi slaves. Michal Suchanek <hramrach@gmail.com> - 2016-07-19 13:20 +0200
        Re: [PATCH v3 1/3] spi: spidev: create spidev device for all spi  slaves. Mark Brown <broonie@kernel.org> - 2016-07-19 14:50 +0200
          Re: [PATCH v3 1/3] spi: spidev: create spidev device for all spi slaves. Michal Suchanek <hramrach@gmail.com> - 2016-07-19 17:40 +0200
            Re: [PATCH v3 1/3] spi: spidev: create spidev device for all spi  slaves. Mark Brown <broonie@kernel.org> - 2016-07-19 19:30 +0200
              Re: [PATCH v3 1/3] spi: spidev: create spidev device for all spi slaves. Michal Suchanek <hramrach@gmail.com> - 2016-07-19 20:40 +0200
    Re: [lkp] [PATCH v3 1/3] spi: spidev: create spidev device for all  spi slaves. Fengguang Wu <fengguang.wu@intel.com> - 2016-07-20 09:20 +0200
  [PATCH v3 3/3] spi: core: allow creating devices without spi-max-frequency Michal Suchanek <hramrach@gmail.com> - 2016-07-19 00:40 +0200

csiph-web