Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1445807

[PATCH net] bnxt_en: Remove locking around txr->dev_state

Show all headers | View raw

txr->dev_state was not consistently manipulated with the acquisition of
the per-queue lock, after further inspection the lock does not seem
necessary, either the value is read as BNXT_DEV_STATE_CLOSING or 0.

Reported-by: coverity (CID 1339583)
Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet driver.")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes in v2:

- remove locking in bnxt_tx_disable() as recommended by Michael

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index c777cde85ce4..15e1d1885919 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -4580,9 +4580,7 @@ static void bnxt_tx_disable(struct bnxt *bp)
 		for (i = 0; i < bp->tx_nr_rings; i++) {
 			txr = &bp->tx_ring[i];
 			txq = netdev_get_tx_queue(bp->dev, i);
-			__netif_tx_lock(txq, smp_processor_id());
 			txr->dev_state = BNXT_DEV_STATE_CLOSING;
-			__netif_tx_unlock(txq);
 		}
 	}
 	/* Stop all TX queues */
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net] bnxt_en: Fix potential race condition in bnxt_tx_enable() Florian Fainelli <f.fainelli@gmail.com> - 2016-07-16 01:50 +0200
  Re: [PATCH net] bnxt_en: Fix potential race condition in  bnxt_tx_enable() David Miller <davem@davemloft.net> - 2016-07-16 08:30 +0200
    Re: [PATCH net] bnxt_en: Fix potential race condition in bnxt_tx_enable() Michael Chan <michael.chan@broadcom.com> - 2016-07-18 13:40 +0200
  Re: [PATCH net] bnxt_en: Remove locking around txr->dev_state Michael Chan <michael.chan@broadcom.com> - 2016-07-18 22:10 +0200
  [PATCH net] bnxt_en: Remove locking around txr->dev_state Florian Fainelli <f.fainelli@gmail.com> - 2016-07-18 22:10 +0200
    Re: [PATCH net] bnxt_en: Remove locking around txr->dev_state David Miller <davem@davemloft.net> - 2016-07-20 04:30 +0200

csiph-web