Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1444677

[PATCH net] bnxt_en: Fix potential race condition in bnxt_tx_enable()

Show all headers | View raw

txr->dev_state is always manipulated after acquiring the transmit queue
lock, except in bnxt_tx_enable(), which seems suspicious here, so also
acquire the transmit queue lock before changing the value.

Reported-by: coverity (CID 1339583)
Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet driver.")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index c777cde85ce4..904c2a8ece12 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -4599,7 +4599,9 @@ static void bnxt_tx_enable(struct bnxt *bp)
 	for (i = 0; i < bp->tx_nr_rings; i++) {
 		txr = &bp->tx_ring[i];
 		txq = netdev_get_tx_queue(bp->dev, i);
+		__netif_tx_lock(txq, smp_processor_id());
 		txr->dev_state = 0;
+		__netif_tx_unlock(txq);
 	}
 	netif_tx_wake_all_queues(bp->dev);
 	if (bp->link_info.link_up)
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH net] bnxt_en: Fix potential race condition in bnxt_tx_enable() Florian Fainelli <f.fainelli@gmail.com> - 2016-07-16 01:50 +0200
  Re: [PATCH net] bnxt_en: Fix potential race condition in  bnxt_tx_enable() David Miller <davem@davemloft.net> - 2016-07-16 08:30 +0200
    Re: [PATCH net] bnxt_en: Fix potential race condition in bnxt_tx_enable() Michael Chan <michael.chan@broadcom.com> - 2016-07-18 13:40 +0200
  Re: [PATCH net] bnxt_en: Remove locking around txr->dev_state Michael Chan <michael.chan@broadcom.com> - 2016-07-18 22:10 +0200
  [PATCH net] bnxt_en: Remove locking around txr->dev_state Florian Fainelli <f.fainelli@gmail.com> - 2016-07-18 22:10 +0200
    Re: [PATCH net] bnxt_en: Remove locking around txr->dev_state David Miller <davem@davemloft.net> - 2016-07-20 04:30 +0200

csiph-web