Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1445596
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Nicolas Pitre <nicolas.pitre@linaro.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 10/10] binfmt_flat: allow compressed flat binary format to work on MMU systems |
| Date | Mon, 18 Jul 2016 17:50:01 +0200 |
| Message-ID | <rWiXT-85S-3@gated-at.bofh.it> (permalink) |
| References | <rW7zs-T6-3@gated-at.bofh.it> <rW7zs-T6-9@gated-at.bofh.it> <rWfdE-5Cg-7@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=eG4Z2bgru14JPTL7N4DQ24rGl0RqCMbDfDRxmY4sUVw=; b=OYVf9Zcma3MireiKrKIu+UlZKyuR/EGWwyzZUMtYRO+//naRNPpJIZe7ubbG7Rz5X2 LmjazYdcyhlL9/GADUCWnbeh/SSZ6A7c0SHPkieyLABVJiJoH0vwel7KUbPSmk6ReMhr 1p5q43VDM0lVvl+a6e9mV3UAx1mzyj7aDVXpU= |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=eG4Z2bgru14JPTL7N4DQ24rGl0RqCMbDfDRxmY4sUVw=; b=ms8ulOi4AfbARuD0j+sRjkn2n3RzBDUU1ac3SQjpG7AzL7y616k1jjZOJ/u+ZN+tQW xIzxxwWhdh3rhsNrQ433XBNHVuQ94aAijMFx0s6ZDKEQrGxgnWoPvpI4NX8iwWh5a7tg IhWb+finxhKkBYRZC3dAZM4zXIPPvA428je/ZIupTHDHGSHCfhuIpGvmJZDYydxdWFdi 2D8C9pozUztulMIOihgry3lHRuRRAoxoEfr+SY9sXx7Qaz0hHx4xDfknFOysn+/q0Znf mz/iJVx9sH1st1gI3M0q15QS28rzajAsEGLbsO39p4OJt/HmyDaSoSx/ILsV1n02mQgS uOBg== |
| X-Gm-Message-State | ALyK8tK4m2ES+av6M6z0VxeM55lxOtMKLw5GJ4iFN1gjSF6Asf8RpQ+368cktYwLDLqYyusO |
| X-Received | by 10.55.168.2 with SMTP id r2mr46136230qke.24.1468856834077; Mon, 18 Jul 2016 08:47:14 -0700 (PDT) |
| User-Agent | Alpine 2.20 (DEB 67 2015-01-07) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=US-ASCII |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 55 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>, David Howells <dhowells@redhat.com>, Greg Ungerer <gerg@linux-m68k.org> |
| X-Original-Date | Mon, 18 Jul 2016 11:45:53 -0400 (EDT) |
| X-Original-Message-ID | <alpine.DEB.2.20.1607181006190.9597@Yrabib> |
| X-Original-References | <1468812716-30537-1-git-send-email-nicolas.pitre@linaro.org> <1468812716-30537-11-git-send-email-nicolas.pitre@linaro.org> <20160718124707.6adfa9a1@lxorguk.ukuu.org.uk> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1445596 |
Show key headers only | View raw
On Mon, 18 Jul 2016, One Thousand Gnomes wrote:
> On Sun, 17 Jul 2016 23:31:56 -0400
> Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
>
> > Let's take the simple and obvious approach by decompressing the binary
> > into a kernel buffer and then copying it to user space. Those who are
> > looking for more performance on a MMU system are unlikely to choose this
> > executable format anyway.
>
> The flat loader takes a very casual attitude to overruns and corrupted
> binaries. It's after all MMUless so has no real security model. If you
> enable flat for an MMU system then IMHO those all need to be fixed
> including all the missing overflow checks on the maths on textlen and the
> like.
What about the following patch? This with existing user accessors and
allocation error checks should cover it all.
----- >8
commit cc1051c9c57202772568600e96b75229a2a7cf19
Author: Nicolas Pitre <nicolas.pitre@linaro.org>
Date: Mon Jul 18 11:28:57 2016 -0400
binfmt_flat: prevent kernel dammage from corrupted executable headers
Signed-off-by: Nicolas Pitre <nico@linaro.org>
diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
index 24deae4dcb..fa0054c1c3 100644
--- a/fs/binfmt_flat.c
+++ b/fs/binfmt_flat.c
@@ -498,6 +498,17 @@ static int load_flat_file(struct linux_binprm * bprm,
}
/*
+ * Make sure the header params are sane.
+ * 28 bits (256 MB) is way more than reasonable in this case.
+ * If some top bits are set we have probable binary corruption.
+ */
+ if ((text_len | data_len | bss_len | stack_len | full_data) >> 28) {
+ printk("BINFMT_FLAT: bad header\n");
+ ret = -ENOEXEC;
+ goto err;
+ }
+
+ /*
* fix up the flags for the older format, there were all kinds
* of endian hacks, this only works for the simple cases
*/
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 10/10] binfmt_flat: allow compressed flat binary format to work on MMU systems Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-18 05:40 +0200
Re: [PATCH v2 10/10] binfmt_flat: allow compressed flat binary format to work on MMU systems One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-07-18 13:50 +0200
Re: [PATCH v2 10/10] binfmt_flat: allow compressed flat binary format to work on MMU systems Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-18 17:50 +0200
Re: [PATCH v2 10/10] binfmt_flat: allow compressed flat binary format to work on MMU systems One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-07-18 19:00 +0200
Re: [PATCH v2 10/10] binfmt_flat: allow compressed flat binary format to work on MMU systems Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-18 19:00 +0200
csiph-web