Re: [PATCH v2 10/10] binfmt_flat: allow compressed flat binary format to work on MMU systems

From	One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 10/10] binfmt_flat: allow compressed flat binary format to work on MMU systems
Date	2016-07-18 13:50 +0200
Message-ID	<rWfdE-5Cg-7@gated-at.bofh.it> (permalink)
References	<rW7zs-T6-3@gated-at.bofh.it> <rW7zs-T6-9@gated-at.bofh.it>
Organization	Intel Corporation

Show all headers | View raw

On Sun, 17 Jul 2016 23:31:56 -0400
Nicolas Pitre <nicolas.pitre@linaro.org> wrote:

> Let's take the simple and obvious approach by decompressing the binary
> into a kernel buffer and then copying it to user space.  Those who are
> looking for more performance on a MMU system are unlikely to choose this
> executable format anyway.

The flat loader takes a very casual attitude to overruns and corrupted
binaries. It's after all MMUless so has no real security model. If you
enable flat for an MMU system then IMHO those all need to be fixed
including all the missing overflow checks on the maths on textlen and the
like.

Thread

[PATCH v2 10/10] binfmt_flat: allow compressed flat binary format to work on MMU systems Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-18 05:40 +0200
  Re: [PATCH v2 10/10] binfmt_flat: allow compressed flat binary  format to work on MMU systems One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-07-18 13:50 +0200
    Re: [PATCH v2 10/10] binfmt_flat: allow compressed flat binary format  to work on MMU systems Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-18 17:50 +0200
      Re: [PATCH v2 10/10] binfmt_flat: allow compressed flat binary  format to work on MMU systems One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-07-18 19:00 +0200
        Re: [PATCH v2 10/10] binfmt_flat: allow compressed flat binary format  to work on MMU systems Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-18 19:00 +0200

csiph-web