Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1445289

Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue instead of vidioc_qbuf

Show all headers | View raw

Hi,

On Fri, Jul 15, 2016 at 12:26:06PM -0400, Javier Martinez Canillas wrote:
> The buffer planes' dma-buf are currently mapped when buffers are queued
> from userspace but it's more appropriate to do the mapping when buffers
> are queued in the driver since that's when the actual DMA operation are
> going to happen.
> 
> Suggested-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> 
> Hello,
> 
> A side effect of this change is that if the dmabuf map fails for some
> reasons (i.e: a driver using the DMA contig memory allocator but CMA
> not being enabled), the fail will no longer happen on VIDIOC_QBUF but
> later (i.e: in VIDIOC_STREAMON).
> 
> I don't know if that's an issue though but I think is worth mentioning.

And for mem2mem devices? Does this mean that the second VIDIOC_STREAMON
will fail? That would make it impossible detect if the buffers on the
capture or the output side are incorrect.

It's already quite difficult to handle these issues gracefully and without
loosing any data. This would make it even worse.

Regards,
Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] [media] vb2: map dmabuf for planes on driver queue instead of vidioc_qbuf Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-15 18:30 +0200
  Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue  instead of vidioc_qbuf Shuah Khan <shuahkh@osg.samsung.com> - 2016-07-15 21:50 +0200
    Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue  instead of vidioc_qbuf Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-16 00:00 +0200
  Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue instead  of vidioc_qbuf Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-07-16 14:20 +0200
  Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue  instead of vidioc_qbuf Michael Olbrich <m.olbrich@pengutronix.de> - 2016-07-18 10:10 +0200
  Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue  instead of vidioc_qbuf Hans Verkuil <hverkuil@xs4all.nl> - 2016-07-18 10:40 +0200
    Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue  instead of vidioc_qbuf Nicolas Dufresne <nicolas@ndufresne.ca> - 2016-07-18 15:40 +0200
    Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue  instead of vidioc_qbuf Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-18 16:20 +0200
  Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue instead  of vidioc_qbuf Marek Szyprowski <m.szyprowski@samsung.com> - 2016-07-18 12:30 +0200
  Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue  instead of vidioc_qbuf Sakari Ailus <sakari.ailus@iki.fi> - 2016-07-20 15:30 +0200
    Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue  instead of vidioc_qbuf Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-20 16:10 +0200
      Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue  instead of vidioc_qbuf Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-20 16:20 +0200
      Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue  instead of vidioc_qbuf Hans Verkuil <hverkuil@xs4all.nl> - 2016-07-20 16:20 +0200

csiph-web